Page MenuHomePhabricator
Differential D3802

[services] Fix clang paths
AbandonedPublic
Actions

Authored by • karol on Apr 21 2022, 12:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 12:15 PM
Unknown Object (File)
Thu, Apr 17, 12:15 PM
Unknown Object (File)
Thu, Apr 17, 12:15 PM
Unknown Object (File)
Thu, Apr 17, 11:25 AM
Unknown Object (File)
Thu, Apr 17, 8:01 AM
Unknown Object (File)
Thu, Apr 17, 5:26 AM
Unknown Object (File)
Wed, Apr 16, 10:38 PM
Unknown Object (File)
Wed, Apr 16, 4:18 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
ashoat
Summary

https://linear.app/comm/issue/ENG-915/services-fix-clang-paths

Fixing clang paths that are broken because of the directory refactoring

Test Plan
yarn clang-format-all

Diff Detail

Repository
rCOMM Comm
Branch
backup-blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 21 2022, 12:16 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 21 2022, 12:16 AM
• karol edited the summary of this revision. (Show Details)Apr 21 2022, 12:18 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3801: [services] Blob - synchronize status access in reactors.
Harbormaster completed remote builds in B8384: Diff 11696.Apr 21 2022, 12:22 AM
• karol requested review of this revision.Apr 21 2022, 12:22 AM
• karol mentioned this in D3738: [services] Backup/Blob - Pull backup logic fixes.Apr 21 2022, 12:22 AM
ashoat accepted this revision.Apr 21 2022, 10:21 AM
This revision is now accepted and ready to land.Apr 21 2022, 10:21 AM
• karol mentioned this in D3485: [services] Backup - Remove backup base Docker image.Apr 22 2022, 3:43 AM
• karol updated this revision to Diff 11794.Apr 22 2022, 5:22 AM

rebase

• karol added a child revision: D3814: [services] Blob - Add holder to the blob DB if data exists.Apr 22 2022, 5:27 AM
Harbormaster completed remote builds in B8455: Diff 11794.Apr 22 2022, 5:30 AM
• karol updated this revision to Diff 12034.Apr 28 2022, 6:16 AM

making this diff standalone

• karol edited the summary of this revision. (Show Details)Apr 28 2022, 6:17 AM
• karol abandoned this revision.Apr 28 2022, 6:19 AM

I want to land this as a standalone change that doesn't depend on anything else.

• karol added a comment.Apr 28 2022, 6:20 AM

New diff D3873

Harbormaster completed remote builds in B8643: Diff 12034.Apr 28 2022, 6:21 AM

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
fbjni/
4 lines
scripts/
12 lines
services/
backup/
src/
Reactors/
2 lines
client/
base-reactors/
4 lines
1 line
1 line
blob/
2 lines
server/
2 lines
base-reactors/
2 lines
1 line
blob/
src/
Reactors/
server/
base-reactors/
2 lines
8 lines
tunnelbroker/
src/
3 lines
test/
3 lines

Diff 11696

View Options

native/android/app/src/main/java/app/comm/android/fbjni/NetworkModule.java

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

scripts/get_clang_paths.js

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

services/backup/src/Reactors/BaseReactor.h

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines
View Options

services/backup/src/Reactors/client/base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/backup/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

Loading...
View Options

services/backup/src/Reactors/client/blob/BlobAppendHolderClientReactor.h

Loading...
View Options

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...
View Options

services/backup/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/backup/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...
View Options

services/tunnelbroker/src/Constants.h

Loading...
View Options

services/tunnelbroker/test/TunnelBrokerTest.cpp

Loading...