Differential D3779 Authored by • karol on Apr 19 2022, 12:11 PM.
Details Summary Depends on D3485 This is more like a best practice, but it's pretty important and may lead to unpleasant errors Test Plan cd services yarn run-backup-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 19 2022, 12:11 PM2022-04-19 12:11:29 (UTC+0) • karol edited the summary of this revision. (Show Details)Apr 19 2022, 12:12 PM2022-04-19 12:12:57 (UTC+0) • karol added a child revision: D3780: [services] Backup - Move reactors' implementations to source files. Harbormaster completed remote builds in B8304: Diff 11600.Apr 19 2022, 12:18 PM2022-04-19 12:18:10 (UTC+0) This revision is now accepted and ready to land.Apr 19 2022, 6:48 PM2022-04-19 18:48:13 (UTC+0) Comment Actions It would be great if we had a tool that would force us to start every header file with this directive Harbormaster completed remote builds in B8445: Diff 11784.Apr 22 2022, 11:01 AM2022-04-22 11:01:33 (UTC+0) Closed by commit rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers. · Explain WhyApr 27 2022, 9:38 AM2022-04-27 09:38:09 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 11600 |