Page MenuHomePhabricator
Differential D3779

[services] Backup - Fix: add missing pragma once to headers
ClosedPublic
Actions

Authored by • karol on Apr 19 2022, 5:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 6:22 PM
Unknown Object (File)
Tue, Apr 8, 5:34 PM
Unknown Object (File)
Tue, Apr 8, 7:24 AM
Unknown Object (File)
Tue, Apr 8, 6:10 AM
Unknown Object (File)
Sun, Apr 6, 3:49 PM
Unknown Object (File)
Sun, Apr 6, 3:45 PM
Unknown Object (File)
Sun, Apr 6, 3:41 PM
Unknown Object (File)
Sun, Apr 6, 3:37 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
ashoat
Commits
rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers
Summary

Depends on D3485

This is more like a best practice, but it's pretty important and may lead to unpleasant errors

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 19 2022, 5:11 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 19 2022, 5:11 AM
• karol edited the summary of this revision. (Show Details)Apr 19 2022, 5:12 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3485: [services] Backup - Remove backup base Docker image.
• karol added a child revision: D3780: [services] Backup - Move reactors' implementations to source files.
Harbormaster completed remote builds in B8304: Diff 11600.Apr 19 2022, 5:18 AM
• karol requested review of this revision.Apr 19 2022, 5:18 AM
ashoat accepted this revision.Apr 19 2022, 11:48 AM
This revision is now accepted and ready to land.Apr 19 2022, 11:48 AM
tomek accepted this revision.Apr 21 2022, 9:16 AM

It would be great if we had a tool that would force us to start every header file with this directive

• karol updated this revision to Diff 11784.Apr 22 2022, 3:44 AM

rebase

• karol added a comment.Apr 22 2022, 3:45 AM

Yes, kind of a shame we all missed that.

Harbormaster completed remote builds in B8445: Diff 11784.Apr 22 2022, 4:01 AM
Closed by commit rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers (authored by • karol). · Explain WhyApr 27 2022, 2:38 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM47ffd8e524ed: [services] Backup - Fix: add missing pragma once to headers.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
client/
base-reactors/
2 lines
2 lines
2 lines

Diff 11600

View Options

services/backup/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Switch, TouchableOpacity, Platform } from 'react-native'; import { View, Switch, TouchableOpacity, Platform } from 'react-native';
import Linking from 'react-native/Libraries/Linking/Linking.js'; import Linking from 'react-native/Libraries/Linking/Linking.js';
import { import {
updateSubscriptionActionTypes, updateSubscriptionActionTypes,
updateSubscription, useUpdateSubscription,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import type { import type {
SubscriptionUpdateRequest, SubscriptionUpdateRequest,
SubscriptionUpdateResult, SubscriptionUpdateResult,
} from 'lib/types/subscription-types.js'; } from 'lib/types/subscription-types.js';
import { type ThreadInfo } from 'lib/types/thread-types.js'; import { type ThreadInfo } from 'lib/types/thread-types.js';
import type { DispatchActionPromise } from 'lib/utils/action-utils.js'; import type { DispatchActionPromise } from 'lib/utils/action-utils.js';
import { import { useDispatchActionPromise } from 'lib/utils/action-utils.js';
useServerCall,
useDispatchActionPromise,
} from 'lib/utils/action-utils.js';
import SingleLine from '../../components/single-line.react.js'; import SingleLine from '../../components/single-line.react.js';
import SWMansionIcon from '../../components/swmansion-icon.react.js'; import SWMansionIcon from '../../components/swmansion-icon.react.js';
import { CommAndroidNotifications } from '../../push/android.js'; import { CommAndroidNotifications } from '../../push/android.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
import Alert from '../../utils/alert.js'; import Alert from '../../utils/alert.js';
▲ Show 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
}; };
const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> = const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> =
React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs( React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs(
props: BaseProps, props: BaseProps,
) { ) {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callUpdateSubscription = useServerCall(updateSubscription); const callUpdateSubscription = useUpdateSubscription();
const hasPushPermissions = useSelector( const hasPushPermissions = useSelector(
state => state.deviceToken !== null && state.deviceToken !== undefined, state => state.deviceToken !== null && state.deviceToken !== undefined,
); );
return ( return (
<ThreadSettingsPushNotifs <ThreadSettingsPushNotifs
{...props} {...props}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateSubscription={callUpdateSubscription} updateSubscription={callUpdateSubscription}
hasPushPermissions={hasPushPermissions} hasPushPermissions={hasPushPermissions}
/> />
); );
}); });
export default ConnectedThreadSettingsPushNotifs; export default ConnectedThreadSettingsPushNotifs;
View Options

services/backup/src/Reactors/client/base-reactors/ClientReadReactorBase.h

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Switch, TouchableOpacity, Platform } from 'react-native'; import { View, Switch, TouchableOpacity, Platform } from 'react-native';
import Linking from 'react-native/Libraries/Linking/Linking.js'; import Linking from 'react-native/Libraries/Linking/Linking.js';
import { import {
updateSubscriptionActionTypes, updateSubscriptionActionTypes,
updateSubscription, useUpdateSubscription,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import type { import type {
SubscriptionUpdateRequest, SubscriptionUpdateRequest,
SubscriptionUpdateResult, SubscriptionUpdateResult,
} from 'lib/types/subscription-types.js'; } from 'lib/types/subscription-types.js';
import { type ThreadInfo } from 'lib/types/thread-types.js'; import { type ThreadInfo } from 'lib/types/thread-types.js';
import type { DispatchActionPromise } from 'lib/utils/action-utils.js'; import type { DispatchActionPromise } from 'lib/utils/action-utils.js';
import { import { useDispatchActionPromise } from 'lib/utils/action-utils.js';
useServerCall,
useDispatchActionPromise,
} from 'lib/utils/action-utils.js';
import SingleLine from '../../components/single-line.react.js'; import SingleLine from '../../components/single-line.react.js';
import SWMansionIcon from '../../components/swmansion-icon.react.js'; import SWMansionIcon from '../../components/swmansion-icon.react.js';
import { CommAndroidNotifications } from '../../push/android.js'; import { CommAndroidNotifications } from '../../push/android.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
import Alert from '../../utils/alert.js'; import Alert from '../../utils/alert.js';
▲ Show 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
}; };
const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> = const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> =
React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs( React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs(
props: BaseProps, props: BaseProps,
) { ) {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callUpdateSubscription = useServerCall(updateSubscription); const callUpdateSubscription = useUpdateSubscription();
const hasPushPermissions = useSelector( const hasPushPermissions = useSelector(
state => state.deviceToken !== null && state.deviceToken !== undefined, state => state.deviceToken !== null && state.deviceToken !== undefined,
); );
return ( return (
<ThreadSettingsPushNotifs <ThreadSettingsPushNotifs
{...props} {...props}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateSubscription={callUpdateSubscription} updateSubscription={callUpdateSubscription}
hasPushPermissions={hasPushPermissions} hasPushPermissions={hasPushPermissions}
/> />
); );
}); });
export default ConnectedThreadSettingsPushNotifs; export default ConnectedThreadSettingsPushNotifs;
View Options

services/backup/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { View, Switch, TouchableOpacity, Platform } from 'react-native'; import { View, Switch, TouchableOpacity, Platform } from 'react-native';
import Linking from 'react-native/Libraries/Linking/Linking.js'; import Linking from 'react-native/Libraries/Linking/Linking.js';
import { import {
updateSubscriptionActionTypes, updateSubscriptionActionTypes,
updateSubscription, useUpdateSubscription,
} from 'lib/actions/user-actions.js'; } from 'lib/actions/user-actions.js';
import type { import type {
SubscriptionUpdateRequest, SubscriptionUpdateRequest,
SubscriptionUpdateResult, SubscriptionUpdateResult,
} from 'lib/types/subscription-types.js'; } from 'lib/types/subscription-types.js';
import { type ThreadInfo } from 'lib/types/thread-types.js'; import { type ThreadInfo } from 'lib/types/thread-types.js';
import type { DispatchActionPromise } from 'lib/utils/action-utils.js'; import type { DispatchActionPromise } from 'lib/utils/action-utils.js';
import { import { useDispatchActionPromise } from 'lib/utils/action-utils.js';
useServerCall,
useDispatchActionPromise,
} from 'lib/utils/action-utils.js';
import SingleLine from '../../components/single-line.react.js'; import SingleLine from '../../components/single-line.react.js';
import SWMansionIcon from '../../components/swmansion-icon.react.js'; import SWMansionIcon from '../../components/swmansion-icon.react.js';
import { CommAndroidNotifications } from '../../push/android.js'; import { CommAndroidNotifications } from '../../push/android.js';
import { useSelector } from '../../redux/redux-utils.js'; import { useSelector } from '../../redux/redux-utils.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
import Alert from '../../utils/alert.js'; import Alert from '../../utils/alert.js';
▲ Show 20 Lines • Show All 142 Lines • ▼ Show 20 Lines
}; };
const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> = const ConnectedThreadSettingsPushNotifs: React.ComponentType<BaseProps> =
React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs( React.memo<BaseProps>(function ConnectedThreadSettingsPushNotifs(
props: BaseProps, props: BaseProps,
) { ) {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callUpdateSubscription = useServerCall(updateSubscription); const callUpdateSubscription = useUpdateSubscription();
const hasPushPermissions = useSelector( const hasPushPermissions = useSelector(
state => state.deviceToken !== null && state.deviceToken !== undefined, state => state.deviceToken !== null && state.deviceToken !== undefined,
); );
return ( return (
<ThreadSettingsPushNotifs <ThreadSettingsPushNotifs
{...props} {...props}
styles={styles} styles={styles}
dispatchActionPromise={dispatchActionPromise} dispatchActionPromise={dispatchActionPromise}
updateSubscription={callUpdateSubscription} updateSubscription={callUpdateSubscription}
hasPushPermissions={hasPushPermissions} hasPushPermissions={hasPushPermissions}
/> />
); );
}); });
export default ConnectedThreadSettingsPushNotifs; export default ConnectedThreadSettingsPushNotifs;