Differential D3531

[services] Backup - Apply reading user id in the reactors
ClosedPublic
Actions

Authored by • karol on Mar 29 2022, 4:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jun 30, 7:28 PM

	Unknown Object (File)
	Sun, Jun 30, 12:07 PM

	Unknown Object (File)
	Sun, Jun 30, 12:07 PM

	Unknown Object (File)
	Sun, Jun 30, 12:07 PM

	Unknown Object (File)
	Sun, Jun 30, 12:07 PM

	Unknown Object (File)
	Sun, Jun 30, 12:04 PM

	Unknown Object (File)
	Sat, Jun 29, 1:56 PM

	Unknown Object (File)
	Fri, Jun 28, 3:11 PM

Subscribers

Details

Reviewers

tomek
• max
varun
• jim

Commits

rCOMMe60ac3c8655c: [services] Backup - Apply reading user id in the reactors

Summary

Depends on D3530

In the previous diff, I added a user id for every request where it was missing. Now, we want to read it when creating a new backup and sending a log.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 29 2022, 4:38 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 29 2022, 4:38 AM

• karol edited the summary of this revision. (Show Details)Mar 29 2022, 4:48 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun, • jim.

• karol edited the summary of this revision. (Show Details)

• karol added a parent revision: D3530: [services] Backup - Fix requests in proto file.

• karol added a child revision: D3532: [services] Backup - Move Service Blob Client.

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2022, 4:53 AM

Harbormaster failed remote builds in B7668: Diff 10764!

• karol requested review of this revision.Mar 29 2022, 4:55 AM

tomek requested changes to this revision.Mar 31 2022, 9:46 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
38	This can be removed
48–54	This code should be introduced before this diff. Is it a mistake due to rebasing?

This revision now requires changes to proceed.Mar 31 2022, 9:46 AM

strip added code(adding it in the next diff), remove comment

• karol added inline comments.Apr 4 2022, 8:08 AM

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
38	right
48–54	Uhm, maybe... Added in D3612

• karol added a child revision: D3612: [services] Backup - Apply reading log chunk in send log reactor.Apr 4 2022, 8:09 AM

Harbormaster completed remote builds in B7839: Diff 11007.Apr 4 2022, 12:28 PM

tomek accepted this revision.Apr 5 2022, 9:20 AM

This revision is now accepted and ready to land.Apr 5 2022, 9:20 AM

Closed by commit rCOMMe60ac3c8655c: [services] Backup - Apply reading user id in the reactors (authored by • karol). · Explain WhyApr 7 2022, 2:38 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMe60ac3c8655c: [services] Backup - Apply reading user id in the reactors.

ashoat added inline comments.Apr 7 2022, 7:56 PM

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h
67 ↗	(On Diff #11147)	I still find it weird that we have a separate trip for each field. I know we have a task out for this but would be great to prioritize it

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

CreateNewBackupReactor.h

18 lines

SendLogReactor.h

28 lines

Diff 10764

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

Loading...

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

Loading...