• karol retitled this revision from [services] Backup - Add server reactor implementations - send log reactor to [draft] [services] Backup - Add server reactor implementations - send log reactor.Mar 24 2022, 2:47 AM

tomek requested changes to this revision.Mar 24 2022, 8:13 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39	Why do we have these definitions in header file?

This revision now requires changes to proceed.Mar 24 2022, 8:13 AM

• karol requested review of this revision.Mar 25 2022, 8:23 AM

• karol added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39	I was having compile errors, here's a task for this https://linear.app/comm/issue/ENG-917/try-to-move-reactors-implementations-to-cpp-files

tomek accepted this revision.Mar 25 2022, 8:42 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39	Thanks for creating the task! But this is strange to have a compilation error as `SendLogReactor` isn't a template, just an ordinary class

This revision is now accepted and ready to land.Mar 25 2022, 8:42 AM

• karol added inline comments.Mar 28 2022, 2:57 AM

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
29–39	Right, I might've been wrong in this particular case, or maybe not. Let's follow up in the task.

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Backup - Add server reactor implementations - send log reactor to [services] Backup - Add server reactor implementations - send log reactor.Mar 28 2022, 3:48 AM

todo remove logs

I decided to leave logs but I added TODOs

Harbormaster failed remote builds in B7633: Diff 10721!Mar 28 2022, 4:12 AM

• karol planned changes to this revision.Mar 28 2022, 4:33 AM

rebuild

Harbormaster completed remote builds in B7640: Diff 10728.Mar 28 2022, 4:49 AM

tomek accepted this revision.Mar 28 2022, 9:53 AM

This revision is now accepted and ready to land.Mar 28 2022, 9:53 AM

Closed by commit rCOMMa54d824439a5: [services] Backup - Add server reactor implementations - send log reactor (authored by • karol). · Explain WhyMar 31 2022, 11:35 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMa54d824439a5: [services] Backup - Add server reactor implementations - send log reactor.