• karol retitled this revision from [services] Backup - Add client reactor base classes - read reactor to [draft] [services] Backup - Add client reactor base classes - read reactor.Mar 24 2022, 9:47 AM

tomek accepted this revision.Mar 24 2022, 1:15 PM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
3	Do we need this?

This revision is now accepted and ready to land.Mar 24 2022, 1:15 PM

• karol added inline comments.Mar 25 2022, 2:10 PM

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
3	No

remove functional header

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

Harbormaster completed remote builds in B7607: Diff 10682.Mar 25 2022, 2:49 PM

tomek accepted this revision.Mar 28 2022, 4:45 PM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
37–38 ↗	(On Diff #10682)	We should include some info about the context, e.g. which reactor logged it

This revision is now accepted and ready to land.Mar 28 2022, 4:45 PM

tomek added inline comments.Mar 28 2022, 4:47 PM

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
46 ↗	(On Diff #10682)	Do we need to make sure that this is called exactly once?

• karol added inline comments.Mar 29 2022, 7:27 AM

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h
37–38 ↗	(On Diff #10682)	logs like this will be removed. If we need to log at the end of the connection, we can always override `doneCallback`.
46 ↗	(On Diff #10682)	I think so... I didn't find anything in the code that would lead to such reasoning but I intentionally called it twice and received a crash. Thanks!