Differential D3727

[services] Backup/Blob - Add comments to delete this
ClosedPublic
Actions

Authored by • karol on Apr 14 2022, 3:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 17, 9:06 AM

	Unknown Object (File)
	Thu, Apr 17, 3:57 AM

	Unknown Object (File)
	Thu, Apr 17, 2:09 AM

	Unknown Object (File)
	Wed, Apr 16, 10:31 AM

	Unknown Object (File)
	Fri, Apr 11, 3:34 AM

	Unknown Object (File)
	Tue, Apr 8, 6:10 PM

	Unknown Object (File)
	Tue, Apr 8, 6:02 PM

	Unknown Object (File)
	Tue, Apr 8, 5:41 PM

Subscribers

Details

Reviewers

tomek
ashoat

Commits

rCOMMc36fd0770f7a: [services] Backup/Blob - Add comments to delete this

Summary

Depends on D3722

https://linear.app/comm/issue/ENG-960/add-comments-for-delete-this

Test Plan

None - these are just comments

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 14 2022, 3:21 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 14 2022, 3:21 AM

• karol edited the summary of this revision. (Show Details)Apr 14 2022, 3:24 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3722: [services] Backup - return error when inner client reactor fails.

• karol added a child revision: D3728: [services] Backup/Blob - Hide nextWrite, expose start.

Harbormaster completed remote builds in B8198: Diff 11469.Apr 14 2022, 3:26 AM

• karol requested review of this revision.Apr 14 2022, 3:26 AM

ashoat accepted this revision.Apr 18 2022, 12:24 PM

This revision is now accepted and ready to land.Apr 18 2022, 12:24 PM

tomek accepted this revision.Apr 21 2022, 1:17 AM

Closed by commit rCOMMc36fd0770f7a: [services] Backup/Blob - Add comments to delete this (authored by • karol). · Explain WhyApr 22 2022, 1:08 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMc36fd0770f7a: [services] Backup/Blob - Add comments to delete this.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

base-reactors/

ServerBidiReactorBase.h

2 lines

ServerReadReactorBase.h

2 lines

ServerWriteReactorBase.h

2 lines

blob/

src/

Reactors/

server/

base-reactors/

ServerBidiReactorBase.h

2 lines

ServerReadReactorBase.h

2 lines

ServerWriteReactorBase.h

2 lines

Diff 11469

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

	#!/bin/bash			#!/usr/bin/env bash

	set -e			set -e

	ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'			ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h

	#!/bin/bash			#!/usr/bin/env bash

	set -e			set -e

	ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'			ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

	#!/bin/bash			#!/usr/bin/env bash

	set -e			set -e

	ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'			ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

	#!/bin/bash			#!/usr/bin/env bash

	set -e			set -e

	ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'			ls \| grep -vE 'base-image\|docker.compose.yml\|package.json\|scripts'

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

Loading...

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...