Page MenuHomePhabricator
Differential D3728

[services] Backup/Blob - Hide nextWrite, expose start
ClosedPublic
Actions

Authored by • karol on Apr 14 2022, 3:22 AM.
Tags
None
Referenced Files
F5127126: D3728.diff
Thu, Apr 3, 10:25 PM
Unknown Object (File)
Tue, Apr 1, 8:51 PM
Unknown Object (File)
Tue, Apr 1, 8:52 AM
Unknown Object (File)
Mon, Mar 31, 2:10 PM
Unknown Object (File)
Sun, Mar 30, 9:15 PM
Unknown Object (File)
Sun, Mar 9, 6:04 PM
Unknown Object (File)
Sun, Mar 9, 6:04 PM
Unknown Object (File)
Sun, Mar 9, 6:04 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
Commits
rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start
Summary

Depends on D3727

https://linear.app/comm/issue/ENG-1002/replace-nextwrite-with-start-in-reactors

Test Plan

The same as D3535 - services should work the same

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 14 2022, 3:22 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 14 2022, 3:22 AM
• karol edited the summary of this revision. (Show Details)Apr 14 2022, 3:25 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D3727: [services] Backup/Blob - Add comments to delete this.
• karol added a child revision: D3729: [services] Backup - Check if log item isn't too big to be stored in the database.
Harbormaster completed remote builds in B8199: Diff 11470.Apr 14 2022, 3:30 AM
• karol requested review of this revision.Apr 14 2022, 3:30 AM
tomek accepted this revision.Apr 21 2022, 1:19 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
64–68

Maybe mention start instead?

This revision is now accepted and ready to land.Apr 21 2022, 1:19 AM
• karol added inline comments.Apr 22 2022, 12:49 AM
services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
64–68

Yes, right, thanks!

• karol updated this revision to Diff 11764.Apr 22 2022, 12:53 AM

fix comments

Harbormaster completed remote builds in B8431: Diff 11764.Apr 22 2022, 12:57 AM
Closed by commit rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start (authored by • karol). · Explain WhyApr 22 2022, 1:08 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
2 lines
Reactors/
client/
base-reactors/
9 lines
8 lines
server/
base-reactors/
16 lines
grpc-client/
2 lines
blob/
src/
2 lines
Reactors/
server/
base-reactors/
16 lines

Diff 11470

View Options

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines
View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines
View Options

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

  • This file was moved from web/modals/threads/thread-settings-modal.react.js.
// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { import {
deleteThreadActionTypes, deleteThreadActionTypes,
changeThreadSettingsActionTypes, changeThreadSettingsActionTypes,
} from 'lib/actions/thread-actions'; } from 'lib/actions/thread-actions.js';
import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors'; import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors.js';
import { threadInfoSelector } from 'lib/selectors/thread-selectors'; import { threadInfoSelector } from 'lib/selectors/thread-selectors.js';
import { threadHasPermission, robotextName } from 'lib/shared/thread-utils'; import { threadHasPermission, robotextName } from 'lib/shared/thread-utils.js';
import { import {
type ThreadInfo, type ThreadInfo,
threadTypes, threadTypes,
threadPermissions, threadPermissions,
type ThreadChanges, type ThreadChanges,
} from 'lib/types/thread-types'; } from 'lib/types/thread-types.js';
import Tabs from '../../components/tabs.react'; import Tabs from '../../../components/tabs.react.js';
import { useModalContext } from '../../modals/modal-provider.react'; import { useSelector } from '../../../redux/redux-utils.js';
import { useSelector } from '../../redux/redux-utils'; import { useModalContext } from '../../modal-provider.react.js';
import Modal from '../modal.react'; import Modal from '../../modal.react.js';
import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react'; import ThreadSettingsDeleteTab from './thread-settings-delete-tab.react.js';
import ThreadSettingsGeneralTab from './thread-settings-general-tab.react'; import ThreadSettingsGeneralTab from './thread-settings-general-tab.react.js';
import css from './thread-settings-modal.css'; import css from './thread-settings-modal.css';
import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react'; import ThreadSettingsPrivacyTab from './thread-settings-privacy-tab.react.js';
type TabType = 'general' | 'privacy' | 'delete'; type TabType = 'general' | 'privacy' | 'delete';
type BaseProps = { type BaseProps = {
+threadID: string, +threadID: string,
}; };
const deleteThreadLoadingStatusSelector = createLoadingStatusSelector( const deleteThreadLoadingStatusSelector = createLoadingStatusSelector(
deleteThreadActionTypes, deleteThreadActionTypes,
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines
View Options

services/blob/src/BlobServiceImpl.cpp

Loading...
View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Loading...