Paths

Table of Contentst

Differential D3728

[services] Backup/Blob - Hide nextWrite, expose start
ClosedPublic
Actions

Authored by • karol on Apr 14 2022, 10:22 AM.

Details

Reviewers

tomek

Commits

rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start

Summary

Depends on D3727

https://linear.app/comm/issue/ENG-1002/replace-nextwrite-with-start-in-reactors

Test Plan

The same as D3535 - services should work the same

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 14 2022, 10:22 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 14 2022, 10:22 AM

• karol edited the summary of this revision. (Show Details)Apr 14 2022, 10:25 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3727: [services] Backup/Blob - Add comments to delete this.

• karol added a child revision: D3729: [services] Backup - Check if log item isn't too big to be stored in the database.

Harbormaster completed remote builds in B8199: Diff 11470.Apr 14 2022, 10:30 AM

• karol requested review of this revision.Apr 14 2022, 10:30 AM

tomek accepted this revision.Apr 21 2022, 8:19 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
64–68	Maybe mention `start` instead?

This revision is now accepted and ready to land.Apr 21 2022, 8:19 AM

• karol added inline comments.Apr 22 2022, 7:49 AM

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
64–68	Yes, right, thanks!

fix comments

Harbormaster completed remote builds in B8431: Diff 11764.Apr 22 2022, 7:57 AM

Closed by commit rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start. · Explain WhyApr 22 2022, 8:08 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMfb4294397173: [services] Backup/Blob - Hide nextWrite, expose start.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

BackupServiceImpl.cpp

2 lines

Reactors/

client/

base-reactors/

ClientBidiReactorBase.h

9 lines

ClientWriteReactorBase.h

8 lines

server/

base-reactors/

ServerWriteReactorBase.h

16 lines

grpc-client/

ServiceBlobClient.h

2 lines

blob/

src/

BlobServiceImpl.cpp

2 lines

Reactors/

server/

base-reactors/

ServerWriteReactorBase.h

16 lines

Diff 11470

View Options

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

View Options

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

View Options

services/blob/src/BlobServiceImpl.cpp

View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

[services] Backup/Blob - Hide nextWrite, expose startClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11470

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

services/blob/src/BlobServiceImpl.cpp

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

[services] Backup/Blob - Hide nextWrite, expose start
ClosedPublic
Actions

Revision Contents
Changeset List