Differential D3729

[services] Backup - Check if log item isn't too big to be stored in the database
ClosedPublic
Actions

Authored by • karol on Apr 14 2022, 3:22 AM.

Details

Reviewers

tomek

Commits

rCOMM9f8fa95e2afa: [services] Backup - Check if log item isn't too big to be stored in the database

Summary

Depends on D3728

https://linear.app/comm/issue/ENG-725/check-for-the-data-size-and-persistinblob-in-logitems-validate

Test Plan

It's hard to come up with a certain test plan here as this is just a sanity check. You can always check whether the service builds as usual:

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Branch

backup-blob

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 14 2022, 3:22 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 14 2022, 3:22 AM

• karol edited the summary of this revision. (Show Details)Apr 14 2022, 3:26 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3728: [services] Backup/Blob - Hide nextWrite, expose start.

Harbormaster completed remote builds in B8200: Diff 11471.Apr 14 2022, 3:34 AM

• karol requested review of this revision.Apr 14 2022, 3:34 AM

• karol added a child revision: D3738: [services] Backup/Blob - Pull backup logic fixes.Apr 15 2022, 1:13 AM

I like diffs like this - it focuses on only one thing and the test plan has an explanation

This revision is now accepted and ready to land.Apr 21 2022, 1:21 AM

In D3729#105034, @palys-swm wrote:

I like diffs like this - it focuses on only one thing and the test plan has an explanation

Thanks! I'm glad you liked it!

Closed by commit rCOMM9f8fa95e2afa: [services] Backup - Check if log item isn't too big to be stored in the database (authored by • karol). · Explain WhyApr 22 2022, 1:08 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM9f8fa95e2afa: [services] Backup - Check if log item isn't too big to be stored in the database.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

DatabaseEntities/

LogItem.cpp

7 lines

Diff 11471

View Options

services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp

[services] Backup - Check if log item isn't too big to be stored in the databaseClosedPublicActions