Differential D3777
[services] Backup - Improve code style in create new backup reactor Authored by • karol on Apr 19 2022, 1:57 AM. Tags None Referenced Files
Details Depends on D3776 Add append holder logic to the create new backup reactor. In a case, the data already exists when creating a new backup, we're just going to add a holder to the existing blob. https://linear.app/comm/issue/ENG-672/create-addreferencetohashbyholder-in-the-blob-service compile the service
Diff Detail
Event TimelineComment Actions Please spend more time thinking about writing readable code. I've repeatedly given you feedback about indentation and control flow. I want to stop having to repeat the same feedback over and over... I really need you to grok and internalize the feedback you're being given
Comment Actions Hey! Thanks for the feedback but honestly I don't think repeating this stuff is necessary. As you observed in D3738, there must be something wrong with the clang-format. In such a case I don't see a point of looking at the following diffs only to spot such problems - it's kind of obvious they'll be there. So in this case, please don't put the blame on me, I understood the comments in D3738 and it's enough for me to take a look at this. There is a task for this: https://linear.app/comm/issue/ENG-915/services-fix-clang-paths It's true I should've probably done this earlier but on the other hand, I had to wait for D3485 (which was blocked by Jim's absence) because that changes the directory structure. I'm going to take care of this soon. Please, do not review any following diffs until then just looking at the coding style, I'm aware of the problem. Comment Actions To be clear, the feedback isn't about clang-format – it's about unnecessarily deeply nested structures of control flow. This sort of stuff
Comment Actions Don't feel super strongly about the inline comment, but I do think it makes readability worse. Curious for @palys-swm's perspective
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||