This is just a copy of D3785... wondering, can we share the BaseReactor definition across services, or is there some reason that it has to be different?

This is a part of https://linear.app/comm/issue/ENG-324/avoid-repetitions-in-services-code

Sorry, added a note to the description that it is a copy

• karol planned changes to this revision.Apr 22 2022, 5:12 AM

rebase

Harbormaster completed remote builds in B8450: Diff 11789.Apr 22 2022, 5:17 AM

See my question above: can we share the BaseReactor definition across services, or is there some reason that it has to be different? (Will request changes this time to make sure it's noticed)

This revision now requires changes to proceed.Apr 22 2022, 11:18 AM

new version of stack

Harbormaster completed remote builds in B8650: Diff 12041.Apr 28 2022, 7:17 AM

can we share the BaseReactor definition across services, or is there some reason that it has to be different?

In D3788#105937, @ashoat wrote:

See my question above: can we share the BaseReactor definition across services, or is there some reason that it has to be different? (Will request changes this time to make sure it's noticed)

Not sure if this is addressed on another diff, but I don't see an answer here...

This revision now requires changes to proceed.Apr 28 2022, 11:45 AM

There is a task for this https://linear.app/comm/issue/ENG-1035/make-sure-the-base-reactor-is-not-copy-pasted-across-multiple-services

I have the same questions as in D3785.

Also, I think that prioritizing code sharing is a really good idea.

Cool thanks, let's follow-up on the task

This revision is now accepted and ready to land.Apr 30 2022, 4:10 PM

Closed by commit rCOMM875fbc6e1c9d: [services] Blob - Pull more mutual code from base reactors - Add base reactor (authored by • karol). · Explain WhyMay 5 2022, 1:47 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM875fbc6e1c9d: [services] Blob - Pull more mutual code from base reactors - Add base reactor.