Paths

Table of Contentst

[services] Blob - Pull more mutual code from base reactors - Apply in server reactors
ClosedPublic
Actions

Authored by • karol on Apr 20 2022, 11:01 AM.

Details

Reviewers

tomek
ashoat

Commits

rCOMMa6a831ba7920: [services] Blob - Pull more mutual code from base reactors - Apply in server…

Summary

Depends on D3788

https://linear.app/comm/issue/ENG-916/consider-pulling-more-mutual-code-from-the-async-reactors

Applying inheriting the BaseRactor in the server reactors

Test Plan

cd services
yarn run-blob-service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 20 2022, 11:01 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 20 2022, 11:01 AM

• karol edited the summary of this revision. (Show Details)Apr 20 2022, 11:04 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

Harbormaster completed remote builds in B8349: Diff 11659.Apr 20 2022, 11:08 AM

• karol requested review of this revision.Apr 20 2022, 11:08 AM

• karol edited the summary of this revision. (Show Details)Apr 20 2022, 11:21 AM

• karol added a parent revision: D3788: [services] Blob - Pull more mutual code from base reactors - Add base reactor.

• karol mentioned this in D3719: [services] Backup - client reactors - distinguish terminated from done.

Let's find a way to avoid using multiple inheritance, see comment in D3786

This revision now requires changes to proceed.Apr 21 2022, 2:56 AM

• karol mentioned this in D3800: [services] Backup - synchronize status access in reactors.Apr 21 2022, 7:01 AM

• karol added a child revision: D3800: [services] Backup - synchronize status access in reactors.

This is similar to D3787 but it seems there are some differences so I'm not tagging it as a copy

rebase

• karol planned changes to this revision.Apr 22 2022, 12:15 PM

In D3789#104873, @ashoat wrote:

Let's find a way to avoid using multiple inheritance, see comment in D3786

planned changes because of this

Harbormaster completed remote builds in B8451: Diff 11790.Apr 22 2022, 12:22 PM

new version of stack

Harbormaster completed remote builds in B8651: Diff 12042.Apr 28 2022, 2:18 PM

ashoat accepted this revision.Apr 28 2022, 6:55 PM

This revision is now accepted and ready to land.Apr 28 2022, 6:55 PM

Closed by commit rCOMMa6a831ba7920: [services] Blob - Pull more mutual code from base reactors - Apply in server…. · Explain WhyMay 5 2022, 8:47 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMa6a831ba7920: [services] Blob - Pull more mutual code from base reactors - Apply in server….

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

Reactors/

server/

base-reactors/

ServerBidiReactorBase.h

63 lines

ServerReadReactorBase.h

88 lines

ServerWriteReactorBase.h

49 lines

Diff 12265

View Options

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

View Options

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

[services] Blob - Pull more mutual code from base reactors - Apply in server reactorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12265

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

[services] Blob - Pull more mutual code from base reactors - Apply in server reactors
ClosedPublic
Actions

Revision Contents
Changeset List