Sorry I missed it!
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Nov 22 2023
Nov 22 2023
I'm guessing you've already considered std::optional?
Nov 21 2023
Nov 21 2023
ashoat added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
Thanks for linking the try-Flow thing – makes it a lot easier for me to confirm the issue
ashoat accepted D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Generally looks right, just a couple comments. Would be great if @atul could take a look as well
tested this by not running my local identity service, triggering the error log. app continued to work fine
Nov 20 2023
Nov 20 2023
ashoat requested changes to D9827: [keyserver/lib/native] Introduce VOICED_IN_ANNOUNCEMENT_CHANNELS thread permission.
Talked about this with @rohan and we realized there's an alternate solution here that will simplify the code we'll need to write in thread-permissions-updaters.js.
This looks good. I was surprised to see that 💂♂️.eth is a legitimate name despite the 3-char limit, but https://ens.domains seems content to register it, so I guess it counts.
ashoat added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
ashoat added a comment to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
One more
ashoat added inline comments to D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.
ashoat updated the diff for D9874: [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos.
Rebase
ashoat updated the diff for D9774: [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated.
Rebase
ashoat updated the diff for D9773: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being underconstrained.
Rebase
ashoat updated the diff for D9771: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors.
Rebase
ashoat updated the diff for D9706: [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that get mutated.
Rebase
ashoat updated the diff for D9692: [Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects.
Rebase
ashoat retitled D9874: [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos from [Flow202][keyserver] [25/x] Fix type error in push notif fetchInfos
ashoat retitled D9873: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors from [Flow202][keyserver] [24/x] Address missing-local-annot type errors
ashoat retitled D9872: [Flow202][keyserver][skip-ci] [23/x] Address type errors in addSessionChangeInfoToResult from [Flow202][keyserver] [23/x] Address type errors in addSessionChangeInfoToResult
ashoat retitled D9871: [Flow202][keyserver][skip-ci] [22/x] Address type errors with getWNSToken from [Flow202][keyserver] [22/x] Address type errors with getWNSToken
ashoat retitled D9870: [Flow202][keyserver][skip-ci] [21/x] Make Date subtraction explicit from [Flow202][keyserver] [21/x] Make Date subtraction explicit
ashoat retitled D9869: [Flow202][keyserver][skip-ci] [20/x] Add any-casts for invalid validator tests from [Flow202][keyserver] [20/x] Add any-casts for invalid validator tests
ashoat retitled D9868: [Flow202][keyserver][skip-ci] [19/x] Fix Flow issues with collection lookup that doesn't match type from [Flow202][keyserver] [19/x] Fix Flow issues with collection lookup that doesn't match type
ashoat retitled D9867: [Flow202][keyserver][skip-ci] [18/x] Fix Flow issues with baseGetENSNames.bind from [Flow202][keyserver] [18/x] Fix Flow issues with baseGetENSNames.bind
ashoat retitled D9866: [Flow202][keyserver][skip-ci] [17/x] Fix type parameterization of accountUpdateInputValidator from [Flow202][keyserver] [17/x] Fix type parameterization of accountUpdateInputValidator
ashoat retitled D9865: [Flow202][keyserver][skip-ci] [16/x] Address type errors in message-fetchers.js from [Flow202][keyserver] [16/x] Address type errors in message-fetchers.js
ashoat retitled D9864: [Flow202][keyserver][skip-ci] [15/x] Fix Flow issues with types being underconstrained from [Flow202][keyserver] [15/x] Fix Flow issues with types being underconstrained
ashoat retitled D9863: [Flow202][keyserver][skip-ci] [14/x] Address type errors with report-responders.js from [Flow202][keyserver] [14/x] Address type errors with report-responders.js
ashoat retitled D9862: [Flow202][keyserver][skip-ci] [13/x] Address type errors with cookie-parser libdef from [Flow202][keyserver] [13/x] Address type errors with cookie-parser libdef
ashoat retitled D9861: [Flow202][keyserver][skip-ci] [12/x] Address type errors with getInitialReduxStateResponder from [Flow202][keyserver] [12/x] Address type errors with getInitialReduxStateResponder
ashoat retitled D9860: [Flow202][keyserver][skip-ci] [11/x] Address type errors with memberOfContainingThread from [Flow202][keyserver] [11/x] Address type errors with memberOfContainingThread
ashoat retitled D9859: [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all from [Flow202][keyserver] [10/x] Address type errors with promiseAll / Promise.all
ashoat retitled D9858: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables that get mutated from [Flow202][keyserver] [9/x] Fix Flow issues with types of variables that get mutated
ashoat retitled D9857: [Flow202][keyserver][skip-ci] [8/x] Address type errors in createPersonalThreads calling createThread from [Flow202][keyserver] [8/x] Address type errors in createPersonalThreads calling createThread
ashoat retitled D9855: [Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state sync specs from [Flow202][keyserver] [7/x] Address and hide type errors with state sync specs
ashoat retitled D9854: [Flow202][keyserver][skip-ci] [6/x] Delete some old scripts that haven't been used in a while from [Flow202][keyserver] [6/x] Delete some old scripts that haven't been used in a while
ashoat retitled D9853: [Flow202][keyserver][skip-ci] [5/x] Address type errors in keyserver/src/push/utils.js from [Flow202][keyserver] [5/x] Address type errors in keyserver/src/push/utils.js
ashoat retitled D9852: [Flow202][keyserver][skip-ci] [4/x] Address type error in rescindPushNotifs from [Flow202][keyserver] [4/x] Address type error in rescindPushNotifs
ashoat retitled D9851: [Flow202][keyserver][skip-ci] [3/x] Address type errors in validateCandidateMembers from [Flow202][keyserver] [3/x] Address type errors in validateCandidateMembers
ashoat retitled D9850: [Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawData from [Flow202][keyserver] [2/x] Address type error in UpdateInfosRawData
ashoat retitled D9849: [Flow202][keyserver][skip-ci] [1/x] Fix Flow issues with conditional changeRole passed to promiseAll from [Flow202][keyserver] [1/x] Fix Flow issues with conditional changeRole passed to promiseAll
ashoat retitled D9786: [Flow202][web][skip-ci] [20/x] Fix Flow issues in ComposedMessage from [Flow202][web] [20/x] Fix Flow issues in ComposedMessage
ashoat retitled D9785: [Flow202][web][skip-ci] [19/x] Fix Flow issues around untyped this parameter from [Flow202][web] [19/x] Fix Flow issues around untyped this parameter
ashoat retitled D9784: [Flow202][web][skip-ci] [18/x] Fix Flow issues in AddUsersList from [Flow202][web] [18/x] Fix Flow issues in AddUsersList
ashoat retitled D9783: [Flow202][web][skip-ci] [17/x] Fix Flow issues in commReduxStorageEngine from [Flow202][web] [17/x] Fix Flow issues in commReduxStorageEngine
ashoat retitled D9782: [Flow202][web][skip-ci] [16/x] Fix Flow issues in ChatInputBar.componentDidUpdate from [Flow202][web] [16/x] Fix Flow issues in ChatInputBar.componentDidUpdate
ashoat retitled D9781: [Flow202][web][skip-ci] [15/x] Fix Flow issues in htmlTargetFromEvent from [Flow202][web] [15/x] Fix Flow issues in htmlTargetFromEvent
ashoat retitled D9780: [Flow202][web][skip-ci] [14/x] Fix Flow issues in web/database from [Flow202][web] [14/x] Fix Flow issues in web/database
ashoat retitled D9779: [Flow202][web][skip-ci] [13/x] Fix Flow issues in unparameterized Promise constructors from [Flow202][web] [13/x] Fix Flow issues in unparameterized Promise constructors
ashoat retitled D9778: [Flow202][web][skip-ci] [12/x] Fix Flow issues with computed properties from [Flow202][web] [12/x] Fix Flow issues with computed properties
ashoat retitled D9777: [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors from [Flow202][web] [11/x] Fix Flow issues in selectors
ashoat retitled D9776: [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in ThreadPickerModal from [Flow202][web] [10/x] Fix nonsensical use of selectors in ThreadPickerModal
ashoat retitled D9775: [Flow202][web][skip-ci] [9/x] Fix Flow issues with types being underconstrained from [Flow202][web] [9/x] Fix Flow issues with types being underconstrained
ashoat retitled D9774: [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated from [Flow202][web] [8/x] Fix Flow issues with types of variables that get mutated
ashoat retitled D9773: [Flow202][web][skip-ci] [7/x] Fix Flow issues with React hooks being underconstrained from [Flow202][web] [7/x] Fix Flow issues with React hooks being underconstrained
ashoat retitled D9772: [Flow202][web][skip-ci] [6/x] Address type errors in community drawer code from [Flow202][web] [6/x] Address type errors in community drawer code
ashoat retitled D9771: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors from [Flow202][web] [5/x] Address missing-local-annot type errors
ashoat retitled D9770: [Flow202][web][skip-ci] [4/x] Extract definition of FetchRevisionsForEntryPayload from [Flow202][web] [4/x] Extract definition of FetchRevisionsForEntryPayload
ashoat retitled D9769: [Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions from [Flow202][web] [3/x] Type React.forwardRef input functions
ashoat retitled D9768: [Flow202][web][skip-ci] [2/x] Address type errors in SubchannelMembersList from [Flow202][web] [2/x] Address type errors in SubchannelMembersList
ashoat retitled D9767: [Flow202][web][skip-ci] [1/x] Fix Flow issues with useDispatch / useSelector being underconstrained from [Flow202][web] [1/x] Fix Flow issues with useDispatch / useSelector being underconstrained
ashoat retitled D9720: [Flow202][landing][skip-ci] [2/2] Fix Flow issues in SIWE code from [Flow202][landing] [2/2] Fix Flow issues in SIWE code
ashoat retitled D9719: [Flow202][landing][skip-ci] [1/2] Fix Flow issues in non-SIWE code from [Flow202][landing] [1/2] Fix Flow issues in non-SIWE code
ashoat retitled D9721: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase from [Flow202][desktop] Fix Flow issues in desktop codebase
ashoat retitled D9751: [Flow202][lib][skip-ci] [26/23] Fix type error in DeviceTokenUpdateRequest from [Flow202][lib] [26/23] Fix type error in DeviceTokenUpdateRequest
ashoat retitled D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs from [Flow202][lib] [25/23] Fix Flow issues from Kamil's recently landed diffs
ashoat retitled D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs from [Flow202][lib] [24/23] Fix Flow issues from Inka's recently landed diffs
ashoat retitled D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js from [Flow202][lib] [23/23][skip-ci] Fix Flow issues in lib/utils/action-logger.js
ashoat retitled D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js from [Flow202][lib] [23/23] Fix Flow issues in lib/utils/action-logger.js to [Flow202][lib] [23/23][skip-ci] Fix Flow issues in lib/utils/action-logger.js.
ashoat retitled D9714: [Flow202][lib][skip-ci] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js from [Flow202][lib] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js
ashoat retitled D9713: [Flow202][lib][skip-ci] [21/23] Fix Flow issues with iterating through chars in a string from [Flow202][lib] [21/23] Fix Flow issues with iterating through chars in a string
ashoat retitled D9712: [Flow202][lib][skip-ci] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js from [Flow202][lib] [20/23] Get rid of $FlowFixMes in lib/utils/objects.js
ashoat retitled D9711: [Flow202][lib][skip-ci] [19/23] Fix Flow issues in unparameterized Promise constructors from [Flow202][lib] [19/23] Fix Flow issues in unparameterized Promise constructors
Nov 19 2023
Nov 19 2023
ashoat retitled D9710: [Flow202][lib][skip-ci] [18/23] Fix Flow issues in lib/socket from [Flow202][lib] [18/23] Fix Flow issues in lib/socket
ashoat retitled D9709: [Flow202][lib][skip-ci] [17/23] Fix Flow issues in lib/shared/state-sync from [Flow202][lib] [17/23] Fix Flow issues in lib/shared/state-sync
ashoat retitled D9708: [Flow202][lib][skip-ci] [16/23] Fix Flow issues in lib/selectors from [Flow202][lib] [16/23] Fix Flow issues in lib/selectors
ashoat retitled D9707: [Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers from [Flow202][lib] [15/23] Fix Flow issues in lib/reducers
ashoat retitled D9706: [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that get mutated from [Flow202][lib] [14/23] Fix Flow issues with types of variables that get mutated
ashoat retitled D9705: [Flow202][lib][skip-ci] [13/23] Fix Flow issues relating to lastPruned that was accidentally left in message-reducer from [Flow202][lib] [13/23] Fix Flow issues relating to lastPruned that was accidentally left in message-reducer
ashoat retitled D9704: [Flow202][lib][skip-ci] [12/23] Fix Flow issues with search-utils.js from [Flow202][lib] [12/23] Fix Flow issues with search-utils.js
ashoat retitled D9703: [Flow202][lib][skip-ci] [11/23] Fix Flow issues with referencing this in object methods from [Flow202][lib] [11/23] Fix Flow issues with referencing this in object methods
ashoat retitled D9702: [Flow202][lib][skip-ci] [10/23] Fix Flow issues with untyped let declarations in entry-reducer from [Flow202][lib] [10/23] Fix Flow issues with untyped let declarations in entry-reducer
ashoat retitled D9701: [Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues from [Flow202][lib] [9/23] Get rid of BigInt $FlowIssues
ashoat retitled D9700: [Flow202][lib][skip-ci] [8/23] Fix Flow issues in cookiesSelector from [Flow202][lib] [8/23] Fix Flow issues in cookiesSelector
ashoat retitled D9699: [Flow202][lib][skip-ci] [7/23] Fix Flow issues in useUpdateThemePreference by replacing let expression with ternary from [Flow202][lib] [7/23] Fix Flow issues in useUpdateThemePreference by replacing let expression with ternary
ashoat retitled D9698: [Flow202][lib][skip-ci] [6/23] Fix Flow issues with computed properties from [Flow202][lib] [6/23] Fix Flow issues with computed properties
ashoat retitled D9697: [Flow202][lib][skip-ci] [5/23] Fix Flow issues with missing annotations on parameters in function declarations from [Flow202][lib] [5/23] Fix Flow issues with missing annotations on parameters in function declarations
ashoat retitled D9696: [Flow202][lib][skip-ci] [4/23] Fix Flow issues with baseGetENSNames.bind from [Flow202][lib] [4/23] Fix Flow issues with baseGetENSNames.bind