Remove base Docker image for backup service and simplify directory structure.
Analogous changes to D3481 and D3234.
Depends on D3778
https://linear.app/comm/issue/ENG-771/service-base-image-cache-inefficiency
Differential D3485 Authored by • karol on Mar 21 2022, 1:35 PM.
Tags None Referenced Files
Subscribers
Details Summary Remove base Docker image for backup service and simplify directory structure. Analogous changes to D3481 and D3234. Depends on D3778 https://linear.app/comm/issue/ENG-771/service-base-image-cache-inefficiency Test Plan cd services yarn run-backup-server
Diff Detail
Event TimelineHerald added subscribers: • benschac, atul, • adrian, tomek. · View Herald TranscriptMar 21 2022, 1:35 PM2022-03-21 13:35:11 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2022, 1:36 PM2022-03-21 13:36:06 (UTC-7) Harbormaster completed remote builds in B7518: Diff 10583.Mar 22 2022, 8:21 AM2022-03-22 08:21:48 (UTC-7) Comment Actions Accepting, but I want to make sure @karol-bisztyga takes a look too since he has the most context Comment Actions Acceptable, but please rebase to the current master and make sure that the backup service builds as there are conflicts. Passing back to you. This revision now requires changes to proceed.Mar 28 2022, 4:45 AM2022-03-28 04:45:02 (UTC-7) Harbormaster completed remote builds in B7850: Diff 11023.Apr 4 2022, 2:26 PM2022-04-04 14:26:19 (UTC-7) Comment Actions @karol-bisztyga can you review this please? It's been a couple days, and this is the kind of diff where you have to painfully rebase whenever there is a delay... Comment Actions Can we wait until the stack @ D3488 is landed? We waited a week for that rebase and during this week I made a lot of progress with that stack. Now, this diff is all about refactoring so it doesn't take much to rename a couple of directories, but if I wanted to rebase my stack to this diff, I'd probably need to resolve a lot of conflicts, etc. This revision now requires changes to proceed.Apr 6 2022, 11:57 PM2022-04-06 23:57:43 (UTC-7) This revision is now accepted and ready to land.Apr 19 2022, 12:56 AM2022-04-19 00:56:38 (UTC-7) This revision is now accepted and ready to land.Apr 19 2022, 3:19 AM2022-04-19 03:19:26 (UTC-7) This revision now requires review to proceed.Apr 19 2022, 3:20 AM2022-04-19 03:20:08 (UTC-7) • karol edited the summary of this revision. (Show Details)Apr 19 2022, 3:21 AM2022-04-19 03:21:01 (UTC-7) • karol retitled this revision from [services] Remove backup base Docker image to [services] Backup - Remove backup base Docker image. Harbormaster completed remote builds in B8302: Diff 11598.Apr 19 2022, 3:26 AM2022-04-19 03:26:09 (UTC-7) • karol edited the summary of this revision. (Show Details)Apr 19 2022, 11:55 PM2022-04-19 23:55:25 (UTC-7) Comment Actions I don't have too much context, but it looks ok. The test plan should include something about formatting by clang-format. We had a lot of issues with something not being formatted properly after being moved, so checking if the code is properly formatted should be a part of the test plan. Harbormaster completed remote builds in B8444: Diff 11783.Apr 22 2022, 3:57 AM2022-04-22 03:57:29 (UTC-7) This revision is now accepted and ready to land.Apr 26 2022, 9:40 AM2022-04-26 09:40:08 (UTC-7) Closed by commit rCOMMa5d1993c343c: [services] Backup - Remove backup base Docker image (authored by • karol). · Explain WhyApr 27 2022, 2:37 AM2022-04-27 02:37:29 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 11023 services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.hLoading... services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.hLoading... services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.hLoading... services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.hLoading... services/backup/docker-server/contents/server/src/Reactors/client/blob/BlobPutClientReactor.hLoading... services/backup/docker-server/contents/server/src/Reactors/client/blob/ServiceBlobClient.hLoading... services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.hLoading... services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.hLoading... services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.hLoading... services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.hLoading... |