Page MenuHomePhabricator
Differential D3626

[services] Backup - client base reactors - terminate on error
ClosedPublic
Actions

Authored by • karol on Apr 6 2022, 7:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:37 AM
Unknown Object (File)
Wed, Nov 20, 4:31 PM
Unknown Object (File)
Sat, Nov 16, 8:37 PM
Unknown Object (File)
Sat, Nov 16, 7:47 PM
Unknown Object (File)
Sat, Nov 16, 1:51 AM
Unknown Object (File)
Sat, Nov 9, 2:25 AM
Unknown Object (File)
Tue, Nov 5, 5:46 PM
Unknown Object (File)
Oct 22 2024, 8:36 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
Commits
rCOMM86a2e7264640: [services] Backup - client base reactors - terminate on error
Summary

Depends on D3610

We should be able to throw in the implemented methods so the connection is gracefully closed with a proper message

Test Plan

The same as in D3535

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 6 2022, 7:34 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 6 2022, 7:34 AM
Harbormaster completed remote builds in B7918: Diff 11100.Apr 6 2022, 7:43 AM
• karol requested review of this revision.Apr 6 2022, 7:43 AM
• karol edited the summary of this revision. (Show Details)Apr 6 2022, 7:48 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D3610: [services] Backup - Set backup id in create new backup reactor's response.
• karol added a child revision: D3627: [services] Backup - Update proto file for pull backup.
tomek requested changes to this revision.Apr 7 2022, 12:10 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h
45–48 ↗(On Diff #11100)

Do we want to call StartWrite after a call to terminate?

This revision now requires changes to proceed.Apr 7 2022, 12:10 AM
• karol added inline comments.Apr 7 2022, 5:51 AM
services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h
45–48 ↗(On Diff #11100)

No, we should definitely return to break execution after invoking terminate, thanks.

• karol updated this revision to Diff 11177.Apr 7 2022, 7:38 AM
• karol edited the summary of this revision. (Show Details)

add return

Harbormaster failed remote builds in B7973: Diff 11177!Apr 7 2022, 7:44 AM
tomek accepted this revision.Apr 8 2022, 2:02 AM
This revision is now accepted and ready to land.Apr 8 2022, 2:02 AM
This revision was landed with ongoing or failed builds.Apr 13 2022, 4:58 AM
Closed by commit rCOMM86a2e7264640: [services] Backup - client base reactors - terminate on error (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM86a2e7264640: [services] Backup - client base reactors - terminate on error.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
client/
base-reactors/
13 lines
12 lines
12 lines

Diff 11177

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

Loading...
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

Loading...