Depends on D3632
Adding basic structure for PullBackupReactor as well as the logic for initializeGetReactor.
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h | ||
|---|---|---|
| 15 ↗ | (On Diff #11179) | Are we using this? Please make sure that the imports are relevant |
| 57 ↗ | (On Diff #11179) | Let's include more details - describe what is missing |
| 67–69 ↗ | (On Diff #11179) | What's the purpose of this function? It is not implemented and not used in this diff. |
| services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h | ||
|---|---|---|
| 15 ↗ | (On Diff #11179) | This can be removed |
| 57 ↗ | (On Diff #11179) | sure |
| 67–69 ↗ | (On Diff #11179) | It is used from the parent class, this is a virtual method that is being called once when the object is initialized. You're right, there's no body of this function and it will throw. We may introduce it in a later diff. |
Comment Actions
update
| services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h | ||
|---|---|---|
| 67–69 ↗ | (On Diff #11179) | Ok I'm getting linker errors without this, I don't think it matters that much to spend more time on this, the body of this function is added in the next diff in this stack. |
| services/backup/docker-server/contents/server/src/Reactors/server/PullBackupReactor.h | ||
|---|---|---|
| 30–32 ↗ | (On Diff #11410) | What's the reason for using shared_ptr for all of these? It seems unnecessary... |