Paths

Table of Contentst

Differential D3647

[services] Backup - Send log - add backup id and log hash states
ClosedPublic
Actions

Authored by • karol on Apr 7 2022, 2:21 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM430640213fac: [services] Backup - Send log - add backup id and log hash states

Summary

Depends on D3646

Adding two missing states for the reactor: BACKUP_ID and LOG_HASH. along with the cases in the reading request method's body.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 7 2022, 2:21 PM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 7 2022, 2:21 PM

• karol edited the summary of this revision. (Show Details)Apr 7 2022, 2:27 PM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3646: [services] Backup - Send log - initialize put reactor method.

• karol added a child revision: D3648: [services] Backup - Send log - add reactor state mutex.Apr 7 2022, 2:29 PM

Harbormaster completed remote builds in B7967: Diff 11171.Apr 7 2022, 3:32 PM

• karol requested review of this revision.Apr 7 2022, 3:32 PM

tomek accepted this revision.Apr 8 2022, 8:23 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
94–104	It is ok to introduce new, unimplemented states, but it would be better if we added them one-by-one, with the implementation. Also, `this->state = State::LOG_CHUNK;` is deleted... shouldn't we replace it with `this->state = State::BACKUP_ID;`?

This revision is now accepted and ready to land.Apr 8 2022, 8:23 AM

• karol added inline comments.Apr 13 2022, 11:19 AM

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
94–104	It is ok to introduce new, unimplemented states, but it would be better if we added them one-by-one, with the implementation. I understand. I'm going to try to remember about this next time. Also, `this->state = State::LOG_CHUNK;` is deleted... shouldn't we replace it with `this->state = State::BACKUP_ID;`? t is added in D3651. Here we return `unimplemented` anyway so there's no point in caring about the correctness of the logic as it's not gonna work here yet anyway.

Closed by commit rCOMM430640213fac: [services] Backup - Send log - add backup id and log hash states. · Explain WhyApr 13 2022, 11:20 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM430640213fac: [services] Backup - Send log - add backup id and log hash states.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

SendLogReactor.h

13 lines

Diff 11171

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

Loading...