Differential D3664 Authored by • karol on Apr 8 2022, 2:33 AM.
Details Summary Depends on D3636 We should make 100% sure that Finish (the method provided by gRPC) is called no more than once. Otherwise, it's going to crash. Test Plan cd services yarn run-blob-service yarn run-backup-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 8 2022, 2:33 AM2022-04-08 02:33:36 (UTC-7) • karol edited the summary of this revision. (Show Details)Apr 8 2022, 2:35 AM2022-04-08 02:35:03 (UTC-7) • karol added a parent revision: D3636: [services] Backup - pull backup reactor - logs - write response. Harbormaster completed remote builds in B8013: Diff 11218.Apr 8 2022, 2:48 AM2022-04-08 02:48:00 (UTC-7) This revision now requires changes to proceed.Apr 10 2022, 7:01 PM2022-04-10 19:01:44 (UTC-7) Harbormaster completed remote builds in B8109: Diff 11336.Apr 12 2022, 1:35 AM2022-04-12 01:35:49 (UTC-7) This revision is now accepted and ready to land.Apr 13 2022, 2:48 AM2022-04-13 02:48:23 (UTC-7) Comment Actions
Good point, we can use it. Harbormaster completed remote builds in B8344: Diff 11654.Apr 20 2022, 12:02 AM2022-04-20 00:02:50 (UTC-7) Closed by commit rCOMM61665dd80d82: [services] Backup/Blob - Make sure Finish is only called once (authored by • karol). · Explain WhyApr 21 2022, 1:49 AM2022-04-21 01:49:17 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 11218 services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.hLoading... services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.hLoading... |