[services] Blob - Add holder to the blob DB if data exists
ClosedPublic
Actions

Authored by • karol on Apr 22 2022, 5:23 AM.

Details

Reviewers

ashoat

Commits

rCOMM0c31fe651db3: [services] Blob - Add holder to the blob DB if data exists

Summary

Depends on D3801

If the data already exists in the blob, we just want to add a new holder pointing to an existing hash.

Test Plan

Like in D3535 and hardcode fixed data hash in the client code, upload twice to the blob and see if it works as expected: it should upload the data only once and add both blobs pointing to the same hash to the database

Diff Detail

Repository

rCOMM Comm

Branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 22 2022, 5:23 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 22 2022, 5:23 AM

• karol edited the summary of this revision. (Show Details)Apr 22 2022, 5:27 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3802: [services] Fix clang paths.

Harbormaster completed remote builds in B8456: Diff 11795.Apr 22 2022, 5:35 AM

• karol requested review of this revision.Apr 22 2022, 5:35 AM

tomek accepted this revision.Apr 26 2022, 10:24 AM

tomek added inline comments.

services/blob/src/Reactors/server/PutReactor.h
81–91 ↗	(On Diff #11795)	This doesn't make sense to check the same condition twice. We can also consider reducing the indentation here, but I'm not sure if it's beneficial