Differential D3463

[services] Backup - Add random string to tools
ClosedPublic
Actions

Authored by • karol on Mar 21 2022, 2:38 AM.

Tags

None

Referenced Files

	F3354620: D3463.diff
	Sat, Nov 23, 1:01 PM

	Unknown Object (File)
	Wed, Nov 20, 4:31 PM

	Unknown Object (File)
	Wed, Nov 20, 4:31 PM

	Unknown Object (File)
	Wed, Nov 20, 8:12 AM

	Unknown Object (File)
	Sun, Nov 17, 9:15 PM

	Unknown Object (File)
	Sat, Nov 16, 9:56 AM

	Unknown Object (File)
	Sat, Nov 16, 1:51 AM

	Unknown Object (File)
	Thu, Nov 7, 11:09 PM

Subscribers

Details

Reviewers

tomek
• jim
• max
varun

Commits

rCOMM7028fb79cf4a: [services] Backup - Add random string to tools

Summary

Depends on D3462

I needed a random string generator for testing the backup service. Once we're done mocking things in this service, this can be removed.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 21 2022, 2:38 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 21 2022, 2:38 AM

Harbormaster completed remote builds in B7484: Diff 10539.Mar 21 2022, 2:50 AM

• karol requested review of this revision.Mar 21 2022, 2:50 AM

• karol edited the summary of this revision. (Show Details)Mar 21 2022, 2:55 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • jim, • max, varun.

• karol added a parent revision: D3462: [services] Backup - Prepare for communication with Blob.

• karol added a child revision: D3464: [services] Backup - Add server reactor base classes - bidi reactor.Mar 21 2022, 3:07 AM

• karol retitled this revision from [services] Backup - Add random string to tools to [draft] [services] Backup - Add random string to tools.Mar 21 2022, 3:09 AM

tomek accepted this revision.Mar 22 2022, 4:55 AM

This revision is now accepted and ready to land.Mar 22 2022, 4:55 AM

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Backup - Add random string to tools to [services] Backup - Add random string to tools.Mar 25 2022, 1:04 AM

tomek accepted this revision.Mar 25 2022, 8:46 AM

This revision is now accepted and ready to land.Mar 25 2022, 8:46 AM

Closed by commit rCOMM7028fb79cf4a: [services] Backup - Add random string to tools (authored by • karol). · Explain WhyMar 28 2022, 12:58 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM7028fb79cf4a: [services] Backup - Add random string to tools.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

2 lines

13 lines

Diff 10539

services/backup/docker-server/contents/server/src/Tools.h

Loading...

services/backup/docker-server/contents/server/src/Tools.cpp

Loading...