Depends on D3464
This class is moved and renamed for a better folder structure.
As we need to add client reactors in order to be able to connect to the blob service, we need to distinguish server reactors from client reactors.
Details
Details
cd services yarn run-backup-service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h | ||
|---|---|---|
| 21 ↗ | (On Diff #10662) | Do we need to make this atomic? |
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h | ||
|---|---|---|
| 30 ↗ | (On Diff #10662) | It's strange that clang-format omits the space between () and {} here, but includes it when it is multiline. Are you sure scripts/get_clang_paths.js is covering this directory? |
Comment Actions
About the threading problem: Let's wait for an answer on the SO. If there's none, we may want to research it on our own. I created a task for this https://linear.app/comm/issue/ENG-914/take-care-of-the-threading-problem-in-the-grpc-async-api
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h | ||
|---|---|---|
| 21 ↗ | (On Diff #10662) | I'm not sure about how to approach changing the reactors' state. In the grpc examples, they do not synchronize the state manually. On the other hand, there may be a problem that you pointed out about not flushing the updated state to the main memory. I saw multiple similar comments from you about this. As this is a bit confusing, I took some time and prepared a question on StackOverflow about this. I hope we get a response from the grpc authors. |
| 30 ↗ | (On Diff #10662) | Yes, clang takes care of this directory. BTW, there are some problems in the scripts/get_clang_paths.js. I'm going to fix this. |
Comment Actions
It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h | ||
|---|---|---|
| 30 ↗ | (On Diff #10662) | I created a task for this https://linear.app/comm/issue/ENG-915/services-fix-clang-paths |