Page MenuHomePhabricator
Differential D3518

[services] Backup - Add server reactor implementations - recover backup key reactor
ClosedPublic
Actions

Authored by • karol on Mar 24 2022, 1:53 AM.
Tags
None
Referenced Files
F3377864: D3518.id10752.diff
Wed, Nov 27, 7:54 AM
F3377793: D3518.id10925.diff
Wed, Nov 27, 7:33 AM
Unknown Object (File)
Wed, Nov 20, 6:35 AM
Unknown Object (File)
Fri, Nov 15, 9:02 AM
Unknown Object (File)
Sat, Nov 9, 2:29 AM
Unknown Object (File)
Oct 27 2024, 4:02 AM
Unknown Object (File)
Oct 16 2024, 3:46 PM
Unknown Object (File)
Oct 13 2024, 6:46 PM
View All Files
Subscribers
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
• jim
Commits
rCOMMc6533b46436e: [services] Backup - Add server reactor implementations - recover backup key…
Summary

Depends on D3516

Add implementation for the recover backup key reactor

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Mar 24 2022, 1:53 AM
Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 24 2022, 1:53 AM
Harbormaster completed remote builds in B7574: Diff 10645.Mar 24 2022, 2:14 AM
• karol requested review of this revision.Mar 24 2022, 2:14 AM
• karol added a child revision: D3468: [services] Backup - Update service implementation.Mar 24 2022, 2:19 AM
• karol edited the summary of this revision. (Show Details)
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun, • jim.
• karol added a parent revision: D3466: [services] Backup - Add blob client.
• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:32 AM
• karol added a parent revision: D3516: [services] Backup - Add server reactor implementations - send log reactor.
• karol retitled this revision from [services] Backup - Add server reactor implementations - recover backup key reactor to [draft] [services] Backup - Add server reactor implementations - recover backup key reactor.Mar 24 2022, 2:47 AM
tomek requested changes to this revision.Mar 24 2022, 8:17 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h
25–30

Can we move it to cpp file?

This revision now requires changes to proceed.Mar 24 2022, 8:17 AM
• karol requested review of this revision.Mar 25 2022, 8:23 AM
• karol added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h
25–30

Here's a task for this https://linear.app/comm/issue/ENG-917/try-to-move-reactors-implementations-to-cpp-files

tomek accepted this revision.Mar 25 2022, 8:44 AM
This revision is now accepted and ready to land.Mar 25 2022, 8:44 AM
• karol updated this revision to Diff 10716.Mar 28 2022, 3:45 AM

update

• karol requested review of this revision.Mar 28 2022, 3:48 AM
• karol retitled this revision from [draft] [services] Backup - Add server reactor implementations - recover backup key reactor to [services] Backup - Add server reactor implementations - recover backup key reactor.

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

Harbormaster failed remote builds in B7628: Diff 10716!Mar 28 2022, 3:54 AM
• karol planned changes to this revision.Mar 28 2022, 4:35 AM
• karol updated this revision to Diff 10729.Mar 28 2022, 4:35 AM

rebuild

Harbormaster completed remote builds in B7641: Diff 10729.Mar 28 2022, 4:53 AM
tomek requested changes to this revision.Mar 28 2022, 9:55 AM

It looks like something went wrong during rebase as this diff (the last revision of it) now contains changes from BackupServiceImpl

This revision now requires changes to proceed.Mar 28 2022, 9:55 AM
• karol updated this revision to Diff 10752.Mar 29 2022, 1:19 AM

fix rebase

Harbormaster completed remote builds in B7657: Diff 10752.Mar 29 2022, 1:30 AM
tomek accepted this revision.Mar 29 2022, 5:23 AM
This revision is now accepted and ready to land.Mar 29 2022, 5:23 AM
Closed by commit rCOMMc6533b46436e: [services] Backup - Add server reactor implementations - recover backup key… (authored by • karol). · Explain WhyMar 31 2022, 11:36 PM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMc6533b46436e: [services] Backup - Add server reactor implementations - recover backup key….

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
34 lines

Diff 10645

View Options

services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h

Loading...