Depends on D3512
This class is moved and renamed for a better folder structure.
As we need to add client reactors in order to be able to connect to the blob service, we need to distinguish server reactors from client reactors.
Details
Details
cd services yarn run-backup-service
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h | ||
|---|---|---|
| 61 | Why do we call directly Finish here while in Read reactor we have terminate method that sets the status. Why status is not needed in this reactor, or why it is needed in that reactor? | |
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h | ||
|---|---|---|
| 61 | you're right, I'm going to add terminate here for the consistency | |
Comment Actions
It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h | ||
|---|---|---|
| 61–66 ↗ | (On Diff #10677) | Could you explain what is the difference and purpose of writeResponse and StartWrite? |
| 85–89 ↗ | (On Diff #10677) | Do we need to wrap it with try-catch when NextWrite also uses try-catch internally? |
| services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h | ||
|---|---|---|
| 61–66 ↗ | (On Diff #10677) | StartWrite is a method provided by the grpc in the grpc::ServerWriteReactor class. It tells the grpc to start writing a response to the client. writeResponse is a method introduced by me. Its purpose is to be implemented in derived classes so we can generate sequential responses that will be sent to the client in derived classes. |
| 85–89 ↗ | (On Diff #10677) | You're right, this is redundant |