• karol retitled this revision from [services] Blob - Add server base reactor classes to [draft] [services] Blob - Add server base reactor classes.Mar 21 2022, 3:18 AM

• karol planned changes to this revision.Mar 24 2022, 2:24 AM

• karol retitled this revision from [draft] [services] Blob - Add server base reactor classes to [draft] [services] Blob - Add server base reactor classes - bidi reactor.

• karol added a child revision: D3519: [services] Blob - Add server base reactor classes - read reactor.

update

Harbormaster completed remote builds in B7584: Diff 10655.Mar 24 2022, 2:50 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:56 AM

Accepting as this is just a copy and we're going to reduce the duplication between services soon

services/blob/CMakeLists.txt
55–56	Should we also update clang-format paths? (probably a lot of other diffs have the same issue)

This revision is now accepted and ready to land.Mar 24 2022, 8:23 AM

Accepting as this is just a copy and we're going to reduce the duplication between services soon

Would be great if this was tracked in a task on Linear!

services/blob/CMakeLists.txt
55–56	I was wondering about this, but I think `scripts/get_clang_paths.js` might be recursive and it already lists `services/blob/docker-server/contents/server/src`

rebase to master

Harbormaster completed remote builds in B7610: Diff 10686.Mar 25 2022, 8:15 AM

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

services/blob/CMakeLists.txt
55–56	it goes recursively

In D3469#95752, @ashoat wrote:

Accepting as this is just a copy and we're going to reduce the duplication between services soon

Would be great if this was tracked in a task on Linear!

https://linear.app/comm/issue/ENG-919/make-sure-reactor-classes-are-not-copy-pasted-across-multiple-services

• karol planned changes to this revision.Mar 28 2022, 3:43 AM

update

Harbormaster completed remote builds in B7630: Diff 10718.Mar 28 2022, 4:04 AM

tomek accepted this revision.Mar 28 2022, 9:02 AM

This revision is now accepted and ready to land.Mar 28 2022, 9:02 AM

ashoat added inline comments.Mar 28 2022, 10:53 AM

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
57 ↗	(On Diff #10718)	Feels sketchy to see `delete this`... is this really the preferred pattern?

terminate when write fails

Harbormaster completed remote builds in B7713: Diff 10815.Mar 30 2022, 5:51 AM

• karol added inline comments.Mar 30 2022, 6:21 AM

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
57 ↗	(On Diff #10718)	I'm almost sure we talked about this but cannot find where it is... gRPC authors did this and it is also said that `delete this` is ok if you don't use that object after doing this.

• karol added inline comments.Mar 30 2022, 6:24 AM

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
57 ↗	(On Diff #10718)	Found the discussion https://phabricator.ashoat.com/D3246#90325 https://phabricator.ashoat.com/D3246#87890

ashoat added inline comments.Mar 30 2022, 10:40 PM

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
57 ↗	(On Diff #10718)	Thanks for linking! If this comes up so often, it seems like something that any reader of this code will ask. Could be good to include a code comment linking to the discussion in each place we use `delete this`. Or just link to a single page on Notion that explains it

• karol mentioned this in D3520: [services] Blob - Add server base reactor classes - write reactor.Mar 31 2022, 11:26 PM

• karol added inline comments.Mar 31 2022, 11:32 PM

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h
57 ↗	(On Diff #10718)	https://linear.app/comm/issue/ENG-960/add-comments-for-delete-this

Closed by commit rCOMMee7e8b3feba9: [services] Blob - Add server base reactor classes - bidi reactor (authored by • karol). · Explain WhyMar 31 2022, 11:39 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMee7e8b3feba9: [services] Blob - Add server base reactor classes - bidi reactor.

Revision Contents
Changeset List

Path

Size

services/

blob/

CMakeLists.txt

2 lines

docker-server/

contents/

server/

src/

Reactors/

server/

base-reactors/

ServerBidiReactorBase.h

93 lines

Diff 10655

View Options

services/blob/CMakeLists.txt

	Show All 20 Lines

	type ContentProps = {			type ContentProps = {
	+threadInfo: ThreadInfo,			+threadInfo: ThreadInfo,
	};			};

	function MessageSearchModal(props: ContentProps): React.Node {			function MessageSearchModal(props: ContentProps): React.Node {
	const { threadInfo } = props;			const { threadInfo } = props;

	const [lastID, setLastID] = React.useState();			const {
	const [searchResults, setSearchResults] = React.useState([]);			getQuery,
	const [endReached, setEndReached] = React.useState(false);			setQuery,
				clearQuery,
				getSearchResults,
				appendSearchResult,
				getEndReached,
				setEndReached,
				} = useMessageSearchContext();

	const { getQuery, setQuery, clearQuery } = useMessageSearchContext();			const loading = React.useRef(false);

	const query = React.useMemo(			const searchResults = React.useMemo(
	() => getQuery(threadInfo.id),			() => getSearchResults(threadInfo.id),
	[getQuery, threadInfo.id],			[getSearchResults, threadInfo.id],
	);			);

	const appendSearchResults = React.useCallback(			const endReached = React.useMemo(
				() => getEndReached(threadInfo.id),
				[getEndReached, threadInfo.id],
				);

				const appendResults = React.useCallback(
	(newMessages: $ReadOnlyArray<RawMessageInfo>, end: boolean) => {			(newMessages: $ReadOnlyArray<RawMessageInfo>, end: boolean) => {
	setSearchResults(oldMessages => [...oldMessages, ...newMessages]);			appendSearchResult(newMessages, threadInfo.id);
	setEndReached(end);			if (end) {
				setEndReached(threadInfo.id);
				}
				loading.current = false;
	},			},
	[],			[appendSearchResult, setEndReached, threadInfo.id],
	);			);

	React.useEffect(() => {
	setSearchResults([]);
	setLastID(undefined);
	setEndReached(false);
	}, [query]);

	const searchMessages = useSearchMessages();			const searchMessages = useSearchMessages();

	React.useEffect(			const [input, setInput] = React.useState(getQuery(threadInfo.id));
	() => searchMessages(query, threadInfo.id, appendSearchResults, lastID),
	[appendSearchResults, lastID, query, searchMessages, threadInfo.id],
	);

	const modifiedItems = useParseSearchResults(threadInfo, searchResults);

	const renderItem = React.useCallback(			const onPressSearch = React.useCallback(() => {
	item => (			setQuery(input, threadInfo.id);
	<MessageResult			loading.current = true;
	key={item.messageInfo.id}			searchMessages(
	item={item}			getQuery(threadInfo.id),
	threadInfo={threadInfo}			threadInfo.id,
	scrollable={false}			appendResults,
	/>			undefined,
	),
	[threadInfo],
	);			);
				}, [setQuery, input, searchMessages, getQuery, threadInfo.id, appendResults]);

	const messages = React.useMemo(			const onKeyDown = React.useCallback(
	() => modifiedItems.map(item => renderItem(item)),			event => {
	[modifiedItems, renderItem],			if (event.key === 'Enter') {
				onPressSearch();
				}
				},
				[onPressSearch],
	);			);

	const messageContainer = React.useRef(null);			const modifiedItems = useParseSearchResults(threadInfo, searchResults);

				const { clearTooltip } = useTooltipContext();

				const messageContainer = React.useRef(null);
	const messageContainerRef = (msgContainer: ?HTMLDivElement) => {			const messageContainerRef = (msgContainer: ?HTMLDivElement) => {
	messageContainer.current = msgContainer;			messageContainer.current = msgContainer;
	messageContainer.current?.addEventListener('scroll', onScroll);
	};			};

	const { clearTooltip } = useTooltipContext();

	const possiblyLoadMoreMessages = React.useCallback(() => {			const possiblyLoadMoreMessages = React.useCallback(() => {
	if (!messageContainer.current) {			if (!messageContainer.current) {
	return;			return;
	}			}

	const loaderTopOffset = 32;			const loaderTopOffset = 32;
	const { scrollTop, scrollHeight, clientHeight } = messageContainer.current;			const { scrollTop, scrollHeight, clientHeight } = messageContainer.current;
	if (			if (
	endReached \|\|			endReached \|\|
				loading.current \|\|
	Math.abs(scrollTop) + clientHeight + loaderTopOffset < scrollHeight			Math.abs(scrollTop) + clientHeight + loaderTopOffset < scrollHeight
	) {			) {
	return;			return;
	}			}
	setLastID(modifiedItems ? oldestMessageID(modifiedItems) : undefined);			loading.current = true;
	}, [endReached, modifiedItems]);			const lastID = modifiedItems ? oldestMessageID(modifiedItems) : undefined;
				searchMessages(
				getQuery(threadInfo.id),
				threadInfo.id,
				appendResults,
				lastID,
				);
				}, [
				appendResults,
				endReached,
				getQuery,
				modifiedItems,
				searchMessages,
				threadInfo.id,
				]);

	const onScroll = React.useCallback(() => {			const onScroll = React.useCallback(() => {
	if (!messageContainer.current) {
	return;
	}
	clearTooltip();			clearTooltip();
	possiblyLoadMoreMessages();			possiblyLoadMoreMessages();
	}, [clearTooltip, possiblyLoadMoreMessages]);			}, [clearTooltip, possiblyLoadMoreMessages]);

				const renderItem = React.useCallback(
				item => (
				<MessageResult
				key={item.messageInfo.id}
				item={item}
				threadInfo={threadInfo}
				scrollable={false}
				/>
				),
				[threadInfo],
				);

				const messages = React.useMemo(
				() => modifiedItems.map(item => renderItem(item)),
				[modifiedItems, renderItem],
				);

	const footer = React.useMemo(() => {			const footer = React.useMemo(() => {
	if (query === '') {			if (getQuery(threadInfo.id) === '') {
	return (			return (
	<div className={css.footer}>Your search results will appear here</div>			<div className={css.footer}>Your search results will appear here</div>
	);			);
	}			}
	if (!endReached) {			if (!endReached) {
	return (			return (
	<div key="search-loader" className={css.loading}>			<div key="search-loader" className={css.loading}>
	<LoadingIndicator status="loading" size="medium" color="white" />			<LoadingIndicator status="loading" size="medium" color="white" />
	</div>			</div>
	);			);
	}			}
	if (modifiedItems.length > 0) {			if (modifiedItems.length > 0) {
	return <div className={css.footer}>End of results</div>;			return <div className={css.footer}>End of results</div>;
	}			}
	return (			return (
	<div className={css.footer}>			<div className={css.footer}>
	No results. Please try using different keywords to refine your search			No results. Please try using different keywords to refine your search
	</div>			</div>
	);			);
	}, [query, endReached, modifiedItems.length]);			}, [getQuery, threadInfo.id, endReached, modifiedItems.length]);

	const [input, setInput] = React.useState(query);

	const onPressSearch = React.useCallback(			const { uiName } = useResolvedThreadInfo(threadInfo);
	() => setQuery(input, threadInfo.id),			const searchPlaceholder = `Searching in ${uiName}`;
	[setQuery, input, threadInfo.id],			const { popModal } = useModalContext();
	);

	const clearQueryWrapper = React.useCallback(			const clearQueryWrapper = React.useCallback(
	() => clearQuery(threadInfo.id),			() => clearQuery(threadInfo.id),
	[clearQuery, threadInfo.id],			[clearQuery, threadInfo.id],
	);			);

	const onKeyDown = React.useCallback(
	event => {
	if (event.key === 'Enter') {
	onPressSearch();
	}
	},
	[onPressSearch],
	);

	const { uiName } = useResolvedThreadInfo(threadInfo);
	const searchPlaceholder = `Searching in ${uiName}`;
	const { popModal } = useModalContext();

	return (			return (
	<Modal name="Search Message" onClose={popModal} size="large">			<Modal name="Search Message" onClose={popModal} size="large">
	<div className={css.container}>			<div className={css.container}>
	<div className={css.header}>			<div className={css.header}>
	<Search			<Search
	onChangeText={setInput}			onChangeText={setInput}
	searchText={input}			searchText={input}
	placeholder={searchPlaceholder}			placeholder={searchPlaceholder}
	onClearText={clearQueryWrapper}			onClearText={clearQueryWrapper}
	onKeyDown={onKeyDown}			onKeyDown={onKeyDown}
	/>			/>
	<Button			<Button
	onClick={onPressSearch}			onClick={onPressSearch}
	variant="filled"			variant="filled"
	className={css.button}			className={css.button}
	>			>
	Search			Search
	</Button>			</Button>
	</div>			</div>
	<div className={css.content} ref={messageContainerRef}>			<div
				className={css.content}
				ref={messageContainerRef}
				onScroll={onScroll}
				>
	{messages}			{messages}
	{footer}			{footer}
	</div>			</div>
	</div>			</div>
	</Modal>			</Modal>
	);			);
	}			}

	Show All 10 Lines

View Options

services/blob/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

	Show All 20 Lines

	type ContentProps = {			type ContentProps = {
	+threadInfo: ThreadInfo,			+threadInfo: ThreadInfo,
	};			};

	function MessageSearchModal(props: ContentProps): React.Node {			function MessageSearchModal(props: ContentProps): React.Node {
	const { threadInfo } = props;			const { threadInfo } = props;

	const [lastID, setLastID] = React.useState();			const {
	const [searchResults, setSearchResults] = React.useState([]);			getQuery,
	const [endReached, setEndReached] = React.useState(false);			setQuery,
				clearQuery,
				getSearchResults,
				appendSearchResult,
				getEndReached,
				setEndReached,
				} = useMessageSearchContext();

	const { getQuery, setQuery, clearQuery } = useMessageSearchContext();			const loading = React.useRef(false);

	const query = React.useMemo(			const searchResults = React.useMemo(
	() => getQuery(threadInfo.id),			() => getSearchResults(threadInfo.id),
	[getQuery, threadInfo.id],			[getSearchResults, threadInfo.id],
	);			);

	const appendSearchResults = React.useCallback(			const endReached = React.useMemo(
				() => getEndReached(threadInfo.id),
				[getEndReached, threadInfo.id],
				);

				const appendResults = React.useCallback(
	(newMessages: $ReadOnlyArray<RawMessageInfo>, end: boolean) => {			(newMessages: $ReadOnlyArray<RawMessageInfo>, end: boolean) => {
	setSearchResults(oldMessages => [...oldMessages, ...newMessages]);			appendSearchResult(newMessages, threadInfo.id);
	setEndReached(end);			if (end) {
				setEndReached(threadInfo.id);
				}
				loading.current = false;
	},			},
	[],			[appendSearchResult, setEndReached, threadInfo.id],
	);			);

	React.useEffect(() => {
	setSearchResults([]);
	setLastID(undefined);
	setEndReached(false);
	}, [query]);

	const searchMessages = useSearchMessages();			const searchMessages = useSearchMessages();

	React.useEffect(			const [input, setInput] = React.useState(getQuery(threadInfo.id));
	() => searchMessages(query, threadInfo.id, appendSearchResults, lastID),
	[appendSearchResults, lastID, query, searchMessages, threadInfo.id],
	);

	const modifiedItems = useParseSearchResults(threadInfo, searchResults);

	const renderItem = React.useCallback(			const onPressSearch = React.useCallback(() => {
	item => (			setQuery(input, threadInfo.id);
	<MessageResult			loading.current = true;
	key={item.messageInfo.id}			searchMessages(
	item={item}			getQuery(threadInfo.id),
	threadInfo={threadInfo}			threadInfo.id,
	scrollable={false}			appendResults,
	/>			undefined,
	),
	[threadInfo],
	);			);
				}, [setQuery, input, searchMessages, getQuery, threadInfo.id, appendResults]);

	const messages = React.useMemo(			const onKeyDown = React.useCallback(
	() => modifiedItems.map(item => renderItem(item)),			event => {
	[modifiedItems, renderItem],			if (event.key === 'Enter') {
				onPressSearch();
				}
				},
				[onPressSearch],
	);			);

	const messageContainer = React.useRef(null);			const modifiedItems = useParseSearchResults(threadInfo, searchResults);

				const { clearTooltip } = useTooltipContext();

				const messageContainer = React.useRef(null);
	const messageContainerRef = (msgContainer: ?HTMLDivElement) => {			const messageContainerRef = (msgContainer: ?HTMLDivElement) => {
	messageContainer.current = msgContainer;			messageContainer.current = msgContainer;
	messageContainer.current?.addEventListener('scroll', onScroll);
	};			};

	const { clearTooltip } = useTooltipContext();

	const possiblyLoadMoreMessages = React.useCallback(() => {			const possiblyLoadMoreMessages = React.useCallback(() => {
	if (!messageContainer.current) {			if (!messageContainer.current) {
	return;			return;
	}			}

	const loaderTopOffset = 32;			const loaderTopOffset = 32;
	const { scrollTop, scrollHeight, clientHeight } = messageContainer.current;			const { scrollTop, scrollHeight, clientHeight } = messageContainer.current;
	if (			if (
	endReached \|\|			endReached \|\|
				loading.current \|\|
	Math.abs(scrollTop) + clientHeight + loaderTopOffset < scrollHeight			Math.abs(scrollTop) + clientHeight + loaderTopOffset < scrollHeight
	) {			) {
	return;			return;
	}			}
	setLastID(modifiedItems ? oldestMessageID(modifiedItems) : undefined);			loading.current = true;
	}, [endReached, modifiedItems]);			const lastID = modifiedItems ? oldestMessageID(modifiedItems) : undefined;
				searchMessages(
				getQuery(threadInfo.id),
				threadInfo.id,
				appendResults,
				lastID,
				);
				}, [
				appendResults,
				endReached,
				getQuery,
				modifiedItems,
				searchMessages,
				threadInfo.id,
				]);

	const onScroll = React.useCallback(() => {			const onScroll = React.useCallback(() => {
	if (!messageContainer.current) {
	return;
	}
	clearTooltip();			clearTooltip();
	possiblyLoadMoreMessages();			possiblyLoadMoreMessages();
	}, [clearTooltip, possiblyLoadMoreMessages]);			}, [clearTooltip, possiblyLoadMoreMessages]);

				const renderItem = React.useCallback(
				item => (
				<MessageResult
				key={item.messageInfo.id}
				item={item}
				threadInfo={threadInfo}
				scrollable={false}
				/>
				),
				[threadInfo],
				);

				const messages = React.useMemo(
				() => modifiedItems.map(item => renderItem(item)),
				[modifiedItems, renderItem],
				);

	const footer = React.useMemo(() => {			const footer = React.useMemo(() => {
	if (query === '') {			if (getQuery(threadInfo.id) === '') {
	return (			return (
	<div className={css.footer}>Your search results will appear here</div>			<div className={css.footer}>Your search results will appear here</div>
	);			);
	}			}
	if (!endReached) {			if (!endReached) {
	return (			return (
	<div key="search-loader" className={css.loading}>			<div key="search-loader" className={css.loading}>
	<LoadingIndicator status="loading" size="medium" color="white" />			<LoadingIndicator status="loading" size="medium" color="white" />
	</div>			</div>
	);			);
	}			}
	if (modifiedItems.length > 0) {			if (modifiedItems.length > 0) {
	return <div className={css.footer}>End of results</div>;			return <div className={css.footer}>End of results</div>;
	}			}
	return (			return (
	<div className={css.footer}>			<div className={css.footer}>
	No results. Please try using different keywords to refine your search			No results. Please try using different keywords to refine your search
	</div>			</div>
	);			);
	}, [query, endReached, modifiedItems.length]);			}, [getQuery, threadInfo.id, endReached, modifiedItems.length]);

	const [input, setInput] = React.useState(query);

	const onPressSearch = React.useCallback(			const { uiName } = useResolvedThreadInfo(threadInfo);
	() => setQuery(input, threadInfo.id),			const searchPlaceholder = `Searching in ${uiName}`;
	[setQuery, input, threadInfo.id],			const { popModal } = useModalContext();
	);

	const clearQueryWrapper = React.useCallback(			const clearQueryWrapper = React.useCallback(
	() => clearQuery(threadInfo.id),			() => clearQuery(threadInfo.id),
	[clearQuery, threadInfo.id],			[clearQuery, threadInfo.id],
	);			);

	const onKeyDown = React.useCallback(
	event => {
	if (event.key === 'Enter') {
	onPressSearch();
	}
	},
	[onPressSearch],
	);

	const { uiName } = useResolvedThreadInfo(threadInfo);
	const searchPlaceholder = `Searching in ${uiName}`;
	const { popModal } = useModalContext();

	return (			return (
	<Modal name="Search Message" onClose={popModal} size="large">			<Modal name="Search Message" onClose={popModal} size="large">
	<div className={css.container}>			<div className={css.container}>
	<div className={css.header}>			<div className={css.header}>
	<Search			<Search
	onChangeText={setInput}			onChangeText={setInput}
	searchText={input}			searchText={input}
	placeholder={searchPlaceholder}			placeholder={searchPlaceholder}
	onClearText={clearQueryWrapper}			onClearText={clearQueryWrapper}
	onKeyDown={onKeyDown}			onKeyDown={onKeyDown}
	/>			/>
	<Button			<Button
	onClick={onPressSearch}			onClick={onPressSearch}
	variant="filled"			variant="filled"
	className={css.button}			className={css.button}
	>			>
	Search			Search
	</Button>			</Button>
	</div>			</div>
	<div className={css.content} ref={messageContainerRef}>			<div
				className={css.content}
				ref={messageContainerRef}
				onScroll={onScroll}
				>
	{messages}			{messages}
	{footer}			{footer}
	</div>			</div>
	</div>			</div>
	</Modal>			</Modal>
	);			);
	}			}

	Show All 10 Lines

[services] Blob - Add server base reactor classes - bidi reactorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10655

services/blob/CMakeLists.txt

services/blob/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

[services] Blob - Add server base reactor classes - bidi reactor
ClosedPublic
Actions

Revision Contents
Changeset List