Page MenuHomePhabricator
Differential D3529

[services] Reactors - use doneCallback only from OnDone
ClosedPublic
Actions

Authored by • karol on Mar 29 2022, 2:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:57 PM
Unknown Object (File)
Sat, Nov 23, 2:43 PM
Unknown Object (File)
Sat, Nov 23, 12:56 PM
Unknown Object (File)
Mon, Nov 18, 9:51 PM
Unknown Object (File)
Wed, Nov 13, 11:24 AM
Unknown Object (File)
Tue, Nov 5, 6:05 PM
Unknown Object (File)
Tue, Nov 5, 6:05 PM
Unknown Object (File)
Tue, Nov 5, 6:05 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
• max
• jim
tomek
varun
Commits
rCOMM7f53dbc5ffa1: [services] Reactors - use doneCallback only from OnDone
Summary

Depends on D3488
We want to use useDoneCallback only from OnDone because OnDone is executed when there are no more grpc operations to perform and we should have access to that if we'd like to release some resources, etc.

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D3488
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Mar 29 2022, 2:10 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 29 2022, 2:10 AM
Harbormaster completed remote builds in B7664: Diff 10759.Mar 29 2022, 2:20 AM
• karol requested review of this revision.Mar 29 2022, 2:20 AM
• karol added reviewers: • max, • jim, tomek, varun.Mar 29 2022, 4:36 AM
• karol added a child revision: D3530: [services] Backup - Fix requests in proto file.Mar 29 2022, 4:46 AM
tomek accepted this revision.Mar 31 2022, 9:40 AM

We have to clearly document it somewhere that doneCallback can only be called from OnDone

This revision is now accepted and ready to land.Mar 31 2022, 9:40 AM
• karol added a comment.Apr 4 2022, 3:25 AM
In D3529#97892, @palys-swm wrote:

We have to clearly document it somewhere that doneCallback can only be called from OnDone

You are right. We should definitely document the base reactor classes and what exactly is going on inside of them.
https://linear.app/comm/issue/ENG-969/add-documentation-for-the-reactor-base-classes

Closed by commit rCOMM7f53dbc5ffa1: [services] Reactors - use doneCallback only from OnDone (authored by • karol). · Explain WhyApr 7 2022, 2:36 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM7f53dbc5ffa1: [services] Reactors - use doneCallback only from OnDone.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
client/
base-reactors/
2 lines
2 lines

Diff 10759

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h

Loading...
View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

Loading...