[services] Backup - Print out errors in reactors
ClosedPublic
Actions

Authored by • karol on Mar 29 2022, 4:39 AM.

Details

Reviewers

• max
tomek
varun
• jim

Commits

rCOMM2daf41aac622: [services] Backup - Print out errors in reactors

Summary

Depends on D3533

I thought we may want to print out error messages in reactors to the stdout in services - for now, they're not visible.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 29 2022, 4:39 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 29 2022, 4:39 AM

• karol edited the summary of this revision. (Show Details)Mar 29 2022, 4:52 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, tomek, varun, • jim.

• karol added a parent revision: D3533: [services] Backup - Fix premature errors crash.

• karol added a child revision: D3535: [services] Backup - Create new backup - Add database operations.

• karol published this revision for review.Mar 29 2022, 4:55 AM

Harbormaster completed remote builds in B7671: Diff 10767.Mar 29 2022, 5:02 AM

tomek accepted this revision.Apr 1 2022, 4:24 AM

This revision is now accepted and ready to land.Apr 1 2022, 4:24 AM

Closed by commit rCOMM2daf41aac622: [services] Backup - Print out errors in reactors (authored by • karol). · Explain WhyApr 7 2022, 2:44 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM2daf41aac622: [services] Backup - Print out errors in reactors.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

client/

base-reactors/

ClientBidiReactorBase.h

3 lines

ClientReadReactorBase.h

3 lines

ClientWriteReactorBase.h

3 lines

server/

base-reactors/

ServerBidiReactorBase.h

3 lines

ServerReadReactorBase.h

3 lines

ServerWriteReactorBase.h

3 lines

blob/

src/

Reactors/

server/

base-reactors/

ServerBidiReactorBase.h

3 lines

ServerReadReactorBase.h

3 lines

Diff 10767

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h

View Options

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

View Options

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

View Options

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

[services] Backup - Print out errors in reactorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10767

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientBidiReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientReadReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/client/base-reactors/ClientWriteReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerReadReactorBase.h

services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerBidiReactorBase.h

services/blob/src/Reactors/server/base-reactors/ServerReadReactorBase.h

[services] Backup - Print out errors in reactors
ClosedPublic
Actions

Revision Contents
Changeset List