Differential D3584
[services] Backup - consider index for BackupItem Authored by • karol on Mar 31 2022, 6:31 AM. Tags None Referenced Files
Details Depends on D3583 For every index we use, we should consider fetching a custom set of fields from the database based on what this index projects. I tried to do it in a couple of different ways, for example with enum/classes/inheritance + the second argument to the assignItemFromDatabase with a default value but all in all, this turned out to be the cleanest way. cd services yarn run-backup-service
Diff Detail
Event TimelineComment Actions It looks like the only difference comparing to assignItemFromDatabase is that we're not setting compactionHolder and attachmentsHolders. In assignItemFromDatabase we check if these are set in itemFromDB and if not, we don't assign them. Could you explain what you mean by
It doesn't look like this code does what you described. We read the data from AttributeValues which has nothing to do with fetching. Please be more precise. Comment Actions The original idea was to create a method for every index. An index is a copy of an original table that projects (contains) a subset of fields of the original table (it may also contain the same set of fields). As for "fetching" - yes, ok, your nit is valid here - it's not about fetching as the data is already fetched, it's about what we pull from that fetched data and insert into BackupItem; in other words, which fields exactly we use while casting from AttributeValues into BackupItem (also, by "fields", I meant "attributes" IIRC, if we want to strictly stick to the dynamo's naming). I think we can abandon here and use assignItemFromDatabase. Nevertheless, the idea from this diff is probably going to be useful someday. |