Page MenuHomePhabricator

[services] Backup - Add server reactor implementations - recover backup key reactor
ClosedPublic

Authored by karol on Mar 24 2022, 1:53 AM.
Tags
None
Referenced Files
F3392182: D3518.id10716.diff
Sat, Nov 30, 7:23 AM
F3392114: D3518.id10645.diff
Sat, Nov 30, 7:00 AM
F3392104: D3518.id10729.diff
Sat, Nov 30, 6:59 AM
F3391848: D3518.diff
Sat, Nov 30, 6:20 AM
Unknown Object (File)
Wed, Nov 27, 7:54 AM
Unknown Object (File)
Wed, Nov 27, 7:33 AM
Unknown Object (File)
Wed, Nov 20, 6:35 AM
Unknown Object (File)
Fri, Nov 15, 9:02 AM

Details

Summary

Depends on D3516

Add implementation for the recover backup key reactor

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol retitled this revision from [services] Backup - Add server reactor implementations - recover backup key reactor to [draft] [services] Backup - Add server reactor implementations - recover backup key reactor.Mar 24 2022, 2:47 AM
tomek requested changes to this revision.Mar 24 2022, 8:17 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h
25–30 ↗(On Diff #10645)

Can we move it to cpp file?

This revision now requires changes to proceed.Mar 24 2022, 8:17 AM
karol added inline comments.
services/backup/docker-server/contents/server/src/Reactors/server/RecoverBackupKeyReactor.h
25–30 ↗(On Diff #10645)
This revision is now accepted and ready to land.Mar 25 2022, 8:44 AM
karol retitled this revision from [draft] [services] Backup - Add server reactor implementations - recover backup key reactor to [services] Backup - Add server reactor implementations - recover backup key reactor.

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

tomek requested changes to this revision.Mar 28 2022, 9:55 AM

It looks like something went wrong during rebase as this diff (the last revision of it) now contains changes from BackupServiceImpl

This revision now requires changes to proceed.Mar 28 2022, 9:55 AM
This revision is now accepted and ready to land.Mar 29 2022, 5:23 AM