Paths

Table of Contentst

Differential D3468

[services] Backup - Update service implementation
ClosedPublic
Actions

Authored by • karol on Mar 21 2022, 2:39 AM.

Tags

None

Referenced Files

	F2906411: D3468.id10723.diff
	Sun, Oct 6, 9:30 AM

	F2906142: D3468.id10753.diff
	Sun, Oct 6, 9:10 AM

	F2906113: D3468.id10927.diff
	Sun, Oct 6, 9:04 AM

	Unknown Object (File)
	Mon, Sep 30, 6:42 PM

	Unknown Object (File)
	Mon, Sep 16, 8:17 AM

	Unknown Object (File)
	Sun, Sep 15, 5:41 AM

	Unknown Object (File)
	Sun, Sep 15, 5:40 AM

	Unknown Object (File)
	Sun, Sep 15, 5:40 AM

Subscribers

Details

Reviewers

• jim
• max
varun
tomek

Commits

rCOMM6cede023718f: [services] Backup - Update service implementation

Summary

Depends on D3518

Use server reactor implementations from the D3467 in the service implementation

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Mar 21 2022, 2:39 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 21 2022, 2:39 AM

update

Harbormaster completed remote builds in B7489: Diff 10544.Mar 21 2022, 3:06 AM

• karol edited the summary of this revision. (Show Details)Mar 21 2022, 3:11 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a parent revision: D3467: [services] Backup - Add server reactor implementations - create new backup reactor.

• karol added a child revision: D3469: [services] Blob - Add server base reactor classes - bidi reactor.

• karol added reviewers: • jim, • max, varun, tomek.

• karol retitled this revision from [services] Backup - Update service implementation to [draft] [services] Backup - Update service implementation.Mar 21 2022, 3:18 AM

Harbormaster completed remote builds in B7493: Diff 10549.Mar 21 2022, 3:20 AM

• karol requested review of this revision.Mar 21 2022, 3:20 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:19 AM

• karol added a parent revision: D3518: [services] Backup - Add server reactor implementations - recover backup key reactor.

• karol planned changes to this revision.Mar 24 2022, 2:44 AM

rebase

Harbormaster completed remote builds in B7588: Diff 10659.Mar 24 2022, 3:06 AM

Nice!

This revision is now accepted and ready to land.Mar 24 2022, 8:21 AM

Love how clean this diff looks!

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Backup - Update service implementation to [services] Backup - Update service implementation.Mar 25 2022, 8:24 AM

tomek accepted this revision.Mar 25 2022, 8:46 AM

This revision is now accepted and ready to land.Mar 25 2022, 8:47 AM

rebase

rebase

This revision is now accepted and ready to land.Mar 28 2022, 4:27 AM

Harbormaster failed remote builds in B7635: Diff 10723!Mar 28 2022, 4:28 AM

The last rebase introduced changes form some other diff RecoverBackupKeyReactor

This revision now requires changes to proceed.Mar 28 2022, 9:56 AM

fix rebase

Harbormaster completed remote builds in B7658: Diff 10753.Mar 29 2022, 1:26 AM

tomek accepted this revision.Mar 29 2022, 5:22 AM

This revision is now accepted and ready to land.Mar 29 2022, 5:22 AM

rebase

This revision was landed with ongoing or failed builds.Mar 31 2022, 11:38 PM

Closed by commit rCOMM6cede023718f: [services] Backup - Update service implementation (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM6cede023718f: [services] Backup - Update service implementation.

Harbormaster completed remote builds in B7788: Diff 10926.Mar 31 2022, 11:44 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

BackupServiceImpl.cpp

68 lines

Diff 10927

services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp

Loading...