Page MenuHomePhabricator
Differential D3610

[services] Backup - Set backup id in create new backup reactor's response
ClosedPublic
Actions

Authored by • karol on Apr 4 2022, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:37 AM
Unknown Object (File)
Sat, Nov 23, 6:19 AM
Unknown Object (File)
Fri, Nov 8, 11:01 AM
Unknown Object (File)
Tue, Nov 5, 5:46 PM
Unknown Object (File)
Oct 19 2024, 3:47 AM
Unknown Object (File)
Oct 13 2024, 4:00 PM
Unknown Object (File)
Oct 13 2024, 4:00 PM
Unknown Object (File)
Oct 13 2024, 3:59 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
varun
• jim
Commits
rCOMM1a7f4c28508f: [services] Backup - Set backup id in create new backup reactor's response
Summary

Depends on D3596

Setting the backup id for the new backup in the reactor's response is missing, this diff fixes it.

Test Plan

The same as in D3535

Diff Detail

Repository
rCOMM Comm
Branch
backup-blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 4 2022, 7:24 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 4 2022, 7:24 AM
• karol edited the summary of this revision. (Show Details)Apr 4 2022, 7:28 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max, varun, • jim.
• karol added a parent revision: D3596: [services] Blob - Fix test name for storage manager tests.
• karol published this revision for review.Apr 4 2022, 8:13 AM

Services build passed and there are changes only in services.

Harbormaster completed remote builds in B7837: Diff 11005.Apr 4 2022, 12:20 PM
• karol added a child revision: D3626: [services] Backup - client base reactors - terminate on error.Apr 6 2022, 7:48 AM
tomek accepted this revision.Apr 7 2022, 12:08 AM

The diff that introduced this code should have a test plan that would caught this issue

This revision is now accepted and ready to land.Apr 7 2022, 12:08 AM
Closed by commit rCOMM1a7f4c28508f: [services] Backup - Set backup id in create new backup reactor's response (authored by • karol). · Explain WhyApr 13 2022, 4:58 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM1a7f4c28508f: [services] Backup - Set backup id in create new backup reactor's response.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
Reactors/
server/
1 line

Diff 11005

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

Loading...