Paths

Table of Contentst

[services] Backup - Use terminateCallback for create new backup reactor
ClosedPublic
Actions

Authored by • karol on Mar 30 2022, 12:04 PM.

Details

Reviewers

tomek
• max
• jim
varun

Commits

rCOMM0d2aef2ffe0a: [services] Backup - Use terminateCallback for create new backup reactor

Summary

Depends on D3560

Use termination callback (added in the previous diff) in CreateNewBackupReactor.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 30 2022, 12:04 PM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 30 2022, 12:04 PM

• karol added a child revision: D3562: [services] Backup - Add hash to send log request.Mar 30 2022, 12:13 PM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, • jim, varun.

• karol added a parent revision: D3560: [services] Backup/Blob - Add terminateCallback.

Harbormaster completed remote builds in B7710: Diff 10812.Mar 30 2022, 12:30 PM

• karol requested review of this revision.Mar 30 2022, 12:30 PM

tomek accepted this revision.Apr 1 2022, 11:59 AM

This revision is now accepted and ready to land.Apr 1 2022, 11:59 AM

rebase

Harbormaster completed remote builds in B7949: Diff 11138.Apr 7 2022, 8:33 AM

Closed by commit rCOMM0d2aef2ffe0a: [services] Backup - Use terminateCallback for create new backup reactor. · Explain WhyApr 7 2022, 9:46 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM0d2aef2ffe0a: [services] Backup - Use terminateCallback for create new backup reactor.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

CreateNewBackupReactor.h

4 lines

Diff 11138

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

[services] Backup - Use terminateCallback for create new backup reactorClosedPublicActions