Paths

Table of Contentst

Differential D3647

[services] Backup - Send log - add backup id and log hash states
ClosedPublic
Actions

Authored by • karol on Apr 7 2022, 7:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 2:31 PM

	Unknown Object (File)
	Thu, Nov 21, 8:44 PM

	Unknown Object (File)
	Fri, Nov 15, 9:04 AM

	Unknown Object (File)
	Tue, Nov 5, 5:55 PM

	Unknown Object (File)
	Oct 13 2024, 3:59 PM

	Unknown Object (File)
	Oct 13 2024, 3:59 PM

	Unknown Object (File)
	Oct 13 2024, 3:59 PM

	Unknown Object (File)
	Oct 13 2024, 3:57 PM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMM430640213fac: [services] Backup - Send log - add backup id and log hash states

Summary

Depends on D3646

Adding two missing states for the reactor: BACKUP_ID and LOG_HASH. along with the cases in the reading request method's body.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.Apr 7 2022, 7:21 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 7 2022, 7:21 AM

• karol edited the summary of this revision. (Show Details)Apr 7 2022, 7:27 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3646: [services] Backup - Send log - initialize put reactor method.

• karol added a child revision: D3648: [services] Backup - Send log - add reactor state mutex.Apr 7 2022, 7:29 AM

Harbormaster completed remote builds in B7967: Diff 11171.Apr 7 2022, 8:32 AM

• karol requested review of this revision.Apr 7 2022, 8:32 AM

tomek accepted this revision.Apr 8 2022, 1:23 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
94–104 ↗	(On Diff #11171)	It is ok to introduce new, unimplemented states, but it would be better if we added them one-by-one, with the implementation. Also, `this->state = State::LOG_CHUNK;` is deleted... shouldn't we replace it with `this->state = State::BACKUP_ID;`?

This revision is now accepted and ready to land.Apr 8 2022, 1:23 AM

• karol added inline comments.Apr 13 2022, 4:19 AM

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
94–104 ↗	(On Diff #11171)	It is ok to introduce new, unimplemented states, but it would be better if we added them one-by-one, with the implementation. I understand. I'm going to try to remember about this next time. Also, `this->state = State::LOG_CHUNK;` is deleted... shouldn't we replace it with `this->state = State::BACKUP_ID;`? t is added in D3651. Here we return `unimplemented` anyway so there's no point in caring about the correctness of the logic as it's not gonna work here yet anyway.

Closed by commit rCOMM430640213fac: [services] Backup - Send log - add backup id and log hash states (authored by • karol). · Explain WhyApr 13 2022, 4:20 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM430640213fac: [services] Backup - Send log - add backup id and log hash states.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

SendLogReactor.h

13 lines

Diff 11394

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h

Loading...