Page MenuHomePhabricator

[services] Backup - Remove backup base Docker image
ClosedPublic

Authored by karol on Mar 21 2022, 1:35 PM.
Tags
None
Referenced Files
F3529349: D3485.diff
Tue, Dec 24, 5:56 PM
Unknown Object (File)
Fri, Dec 20, 1:42 PM
Unknown Object (File)
Fri, Dec 20, 1:42 PM
Unknown Object (File)
Fri, Dec 20, 1:42 PM
Unknown Object (File)
Fri, Dec 20, 1:42 PM
Unknown Object (File)
Fri, Dec 20, 1:42 PM
Unknown Object (File)
Fri, Dec 20, 1:41 PM
Unknown Object (File)
Fri, Dec 20, 1:31 PM

Details

Summary

Remove base Docker image for backup service and simplify directory structure.

Analogous changes to D3481 and D3234.

Depends on D3778

https://linear.app/comm/issue/ENG-771/service-base-image-cache-inefficiency

Test Plan
cd services
yarn run-backup-server

Diff Detail

Repository
rCOMM Comm
Branch
backup-blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2022, 1:36 PM
Harbormaster failed remote builds in B7518: Diff 10583!
ashoat added 1 blocking reviewer(s): karol.

Accepting, but I want to make sure @karol-bisztyga takes a look too since he has the most context

Acceptable, but please rebase to the current master and make sure that the backup service builds as there are conflicts. Passing back to you.

This revision now requires changes to proceed.Mar 28 2022, 4:45 AM

@karol-bisztyga can you review this please? It's been a couple days, and this is the kind of diff where you have to painfully rebase whenever there is a delay...

Can we wait until the stack @ D3488 is landed? We waited a week for that rebase and during this week I made a lot of progress with that stack. Now, this diff is all about refactoring so it doesn't take much to rename a couple of directories, but if I wanted to rebase my stack to this diff, I'd probably need to resolve a lot of conflicts, etc.

This revision now requires changes to proceed.Apr 6 2022, 11:57 PM
karol edited reviewers, added: jim; removed: karol.

Commandeering as discussed with @jimpo

This revision is now accepted and ready to land.Apr 19 2022, 12:56 AM

rebase to my stack

This revision is now accepted and ready to land.Apr 19 2022, 3:19 AM
karol edited reviewers, added: tomek; removed: max. karol added 1 blocking reviewer(s): jim.Apr 19 2022, 3:20 AM
This revision now requires review to proceed.Apr 19 2022, 3:20 AM
karol edited the test plan for this revision. (Show Details)
karol retitled this revision from [services] Remove backup base Docker image to [services] Backup - Remove backup base Docker image.

The sooner we can get this landed, the better!

I don't have too much context, but it looks ok.

The test plan should include something about formatting by clang-format. We had a lot of issues with something not being formatted properly after being moved, so checking if the code is properly formatted should be a part of the test plan.

Hey @jimpo is there any ETA for a review here? It's blocking.

Thanks!

This revision is now accepted and ready to land.Apr 26 2022, 9:40 AM