Differential D3787 Authored by • karol on Apr 20 2022, 3:49 AM.
Tags None Referenced Files
Details Summary Depends on D3786 https://linear.app/comm/issue/ENG-916/consider-pulling-more-mutual-code-from-the-async-reactors Applying inheriting the BaseRactor in the server reactors Test Plan cd services yarn run-backup-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 20 2022, 3:49 AM2022-04-20 03:49:05 (UTC-7) • karol edited the summary of this revision. (Show Details)Apr 20 2022, 3:55 AM2022-04-20 03:55:40 (UTC-7) • karol added a parent revision: D3786: [services] Backup - Pull more mutual code from base reactors - Apply in client reactors. Harbormaster completed remote builds in B8347: Diff 11657.Apr 20 2022, 3:57 AM2022-04-20 03:57:36 (UTC-7) Harbormaster completed remote builds in B8352: Diff 11662.Apr 20 2022, 5:37 AM2022-04-20 05:37:11 (UTC-7) This revision now requires changes to proceed.Apr 20 2022, 7:59 PM2022-04-20 19:59:55 (UTC-7) Harbormaster completed remote builds in B8396: Diff 11712.Apr 21 2022, 3:17 AM2022-04-21 03:17:20 (UTC-7) Comment Actions When you update a diff for a rebase without addressing comments, please hit "Plan Changes" to remove that diff from your reviewers' queue This revision now requires changes to proceed.Apr 21 2022, 10:14 AM2022-04-21 10:14:29 (UTC-7) Harbormaster completed remote builds in B8449: Diff 11788.Apr 22 2022, 5:14 AM2022-04-22 05:14:58 (UTC-7) Comment Actions
planned changes because of this Harbormaster completed remote builds in B8649: Diff 12040.Apr 28 2022, 7:15 AM2022-04-28 07:15:45 (UTC-7) This revision is now accepted and ready to land.Apr 28 2022, 11:55 AM2022-04-28 11:55:33 (UTC-7) Closed by commit rCOMM6bafbe2cce50: [services] Backup - Pull more mutual code from base reactors - Apply in server… (authored by • karol). · Explain WhyMay 5 2022, 1:47 AM2022-05-05 01:47:43 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 11712 |