• karol retitled this revision from [services] Blob - Add server base reactor classes - write reactor to [draft] [services] Blob - Add server base reactor classes - write reactor.Mar 24 2022, 2:47 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:57 AM

tomek accepted this revision.Mar 24 2022, 8:30 AM

This revision is now accepted and ready to land.Mar 24 2022, 8:30 AM

rebase to master

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Blob - Add server base reactor classes - write reactor to [services] Blob - Add server base reactor classes - write reactor.Mar 25 2022, 8:31 AM

Harbormaster completed remote builds in B7612: Diff 10688.Mar 25 2022, 8:33 AM

• karol planned changes to this revision.Mar 29 2022, 1:58 AM

add status reactor

Harbormaster completed remote builds in B7663: Diff 10758.Mar 29 2022, 2:07 AM

tomek accepted this revision.Mar 30 2022, 4:06 AM

This revision is now accepted and ready to land.Mar 30 2022, 4:06 AM

ashoat added inline comments.Mar 30 2022, 10:29 PM

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
69 ↗	(On Diff #10758)	Is `delete this` really the right pattern? (I think I asked this on a different diff but I don't remember seeing the answer)

• karol added inline comments.Mar 31 2022, 11:26 PM

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
69 ↗	(On Diff #10758)	You had the same doubt in another diff, in https://phabricator.ashoat.com/D3469#97534 we seem to be on the same page about this.