[services] Backup - Rename mutex for create new backup
AbandonedPublic
Actions

Authored by • karol on Mar 31 2022, 6:32 AM.

Details

Reviewers

• max
• jim
varun
tomek

Summary

Depends on D3586

Rename mutex in create new backup reactor to be consistent with the send log reactor.

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D3488

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 31 2022, 6:32 AM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptMar 31 2022, 6:32 AM

• karol edited the summary of this revision. (Show Details)Mar 31 2022, 6:45 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, • jim, varun, tomek.

• karol added a parent revision: D3586: [services] Backup - Send log - add store in database.

Harbormaster completed remote builds in B7767: Diff 10883.Mar 31 2022, 7:12 AM

• karol requested review of this revision.Mar 31 2022, 7:12 AM

• karol added a child revision: D3594: [services] Blob - Fix reading data from S3.Apr 1 2022, 3:17 AM

It would be a lot better to modify the original diff instead of adding a followup like this. The rename would significantly improve the readability and this is likely that it will be requested in the original diff.

This revision now requires changes to proceed.Apr 7 2022, 12:04 AM

changed in the original diff

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

CreateNewBackupReactor.h

8 lines

Diff 10883

View Options

services/backup/docker-server/contents/server/src/Reactors/server/CreateNewBackupReactor.h

[services] Backup - Rename mutex for create new backupAbandonedPublicActions