services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
47–55 ↗	(On Diff #11008)	I don't see what's wrong in throwing here - there should never be a state that's not handled, I think this is a good example of an exceptional/unwanted situation. Side note, effectively there's no difference between returning a grpc error and throwing, both result in terminating the reactor with a proper status (see reactor base class code).

tomek requested changes to this revision.Apr 6 2022, 2:24 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h
47–53 ↗	(On Diff #11008)
47–55 ↗	(On Diff #11008)	Are you sure we always want to throw when `LOG_CHUNK` state is processed? Because this is what happens now. I think we need a return as the last statement in `case` just like we have it in the other reactor.

This revision now requires changes to proceed.Apr 6 2022, 2:24 AM

add missing return

This revision is now accepted and ready to land.Apr 7 2022, 12:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

Reactors/

server/

8 lines

Diff 11149

Property	Old Value	New Value
File Mode	null	100755

				#!/usr/bin/env bash

				# This file exists to make a smaller docker context, so that building it is
				# significantly faster and requires less system resources

				SCRIPT_DIR="$(cd "$(dirname "$0")" \|\| exit 1; pwd -P)"
				BUILD_DIR="${SCRIPT_DIR}/target/oci_image"

				rm -rf "$BUILD_DIR"
				mkdir -p "$BUILD_DIR"/{scripts,shared,services/tunnelbroker}

				cp "$SCRIPT_DIR/../../scripts/install_protobuf.sh" "$BUILD_DIR"/scripts
				cp -r "${SCRIPT_DIR}/../../shared/protos" "$BUILD_DIR"/shared/protos
				cp -r "${SCRIPT_DIR}/../../shared/tunnelbroker_messages" \
				"$BUILD_DIR"/shared/tunnelbroker_messages
				cp -r "${SCRIPT_DIR}"/{Cargo.toml,Cargo.lock,build.rs,src} \
				"$BUILD_DIR"/services/tunnelbroker/

				docker build -f "${SCRIPT_DIR}/Dockerfile" "$BUILD_DIR"