Paths

Table of Contentst

Differential D3632

[services] Backup - Implement get method in service blob client
ClosedPublic
Actions

Authored by • karol on Apr 6 2022, 2:37 PM.

Tags

None

Referenced Files

	F32306123: D3632.1765290864.diff
	Mon, Dec 8, 2:34 PM

Subscribers

Details

Reviewers

tomek
• max

Commits

rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client

Summary

Depends on D3630

Just calling Get method in ServiceBlobClient

Test Plan

The same as in D3535

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Apr 6 2022, 2:37 PM

Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 6 2022, 2:37 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 6 2022, 2:51 PM

Harbormaster failed remote builds in B7924: Diff 11106!

• karol edited the summary of this revision. (Show Details)Apr 6 2022, 2:55 PM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D3630: [services] Backup - Add find backup item to database manager.

• karol added a child revision: D3633: [services] Backup - pull backup reactor - initialize get reactor.

retrigger ci

• karol published this revision for review.Apr 7 2022, 12:49 PM

Harbormaster failed remote builds in B7962: Diff 11166!Apr 7 2022, 3:11 PM

tomek accepted this revision.Apr 8 2022, 9:47 AM

tomek added inline comments.

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h
36–46 ↗	(On Diff #11166)	It is slightly inconsistent that we have `nextWrite()` in one reactor and `start` in the other. Can we hide an implementation detail and have `start` in both?

This revision is now accepted and ready to land.Apr 8 2022, 9:47 AM

• karol added inline comments.Apr 13 2022, 12:20 PM

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h
36–46 ↗	(On Diff #11166)	Fair enough but I'd do this in a new diff as it was added in D3465. https://linear.app/comm/issue/ENG-1002/replace-nextwrite-with-start-in-blobgetclientreactor

This revision was landed with ongoing or failed builds.Apr 13 2022, 12:22 PM

Closed by commit rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client.

Revision Contents
Changeset List

Path

Size

services/

backup/

docker-server/

contents/

server/

src/

grpc-client/

ServiceBlobClient.h

12 lines

Diff 11106

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

Loading...