Page MenuHomePhabricator
Differential D3632

[services] Backup - Implement get method in service blob client
ClosedPublic
Actions

Authored by • karol on Apr 6 2022, 7:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 5:36 AM
Unknown Object (File)
Sun, Nov 24, 8:37 AM
Unknown Object (File)
Tue, Nov 5, 5:28 PM
Unknown Object (File)
Oct 13 2024, 3:42 PM
Unknown Object (File)
Oct 13 2024, 3:42 PM
Unknown Object (File)
Oct 13 2024, 3:42 PM
Unknown Object (File)
Oct 13 2024, 3:41 PM
Unknown Object (File)
Oct 13 2024, 3:39 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
tomek

Details

Reviewers
tomek
• max
Commits
rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client
Summary

Depends on D3630

Just calling Get method in ServiceBlobClient

Test Plan

The same as in D3535

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 6 2022, 7:37 AM
Herald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 6 2022, 7:37 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 6 2022, 7:51 AM
Harbormaster failed remote builds in B7924: Diff 11106!
• karol edited the summary of this revision. (Show Details)Apr 6 2022, 7:55 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D3630: [services] Backup - Add find backup item to database manager.
• karol added a child revision: D3633: [services] Backup - pull backup reactor - initialize get reactor.
• karol updated this revision to Diff 11166.Apr 7 2022, 3:34 AM
• karol edited the summary of this revision. (Show Details)

retrigger ci

• karol published this revision for review.Apr 7 2022, 5:49 AM
Harbormaster failed remote builds in B7962: Diff 11166!Apr 7 2022, 8:11 AM
tomek accepted this revision.Apr 8 2022, 2:47 AM
tomek added inline comments.
services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h
36–46

It is slightly inconsistent that we have nextWrite() in one reactor and start in the other. Can we hide an implementation detail and have start in both?

This revision is now accepted and ready to land.Apr 8 2022, 2:47 AM
• karol added inline comments.Apr 13 2022, 5:20 AM
services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h
36–46

Fair enough but I'd do this in a new diff as it was added in D3465. https://linear.app/comm/issue/ENG-1002/replace-nextwrite-with-start-in-blobgetclientreactor

This revision was landed with ongoing or failed builds.Apr 13 2022, 5:22 AM
Closed by commit rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMMfb2954458f33: [services] Backup - Implement get method in service blob client.

Revision Contents
Changeset List

PathSize
services/
backup/
docker-server/
contents/
server/
src/
grpc-client/
12 lines

Diff 11166

View Options

services/backup/docker-server/contents/server/src/grpc-client/ServiceBlobClient.h

Loading...