Depends on D3719
We need to be able to pull the status by external objects from blob client reactors.
Differential D3720 Authored by • karol on Apr 13 2022, 7:04 AM.
Tags None Referenced Files
Details Summary Depends on D3719 We need to be able to pull the status by external objects from blob client reactors. Test Plan cd services yarn run-backup-service
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, atul and 3 others. · View Herald TranscriptApr 13 2022, 7:04 AM2022-04-13 07:04:33 (UTC-7) Harbormaster completed remote builds in B8156: Diff 11418.Apr 13 2022, 7:11 AM2022-04-13 07:11:28 (UTC-7) • karol edited the summary of this revision. (Show Details)Apr 13 2022, 7:13 AM2022-04-13 07:13:03 (UTC-7) • karol added a parent revision: D3719: [services] Backup - client reactors - distinguish terminated from done. • karol added a child revision: D3721: [services] Backup/Blob - wrap terminateCallback into try...catch. Harbormaster completed remote builds in B8159: Diff 11421.Apr 13 2022, 7:25 AM2022-04-13 07:25:08 (UTC-7) This revision now requires changes to proceed.Apr 15 2022, 9:49 AM2022-04-15 09:49:54 (UTC-7) Comment Actions
yes, thanks Comment Actions Synchronizing accessing to state is handled in D3800. I decided it would be better to do this as a follow-up because the easiest and the cleanest way of doing it is to implement it in the master class. Comment Actions
It would be more efficient to think about issues like this before putting a diff - we need to spend more time planning and thinking about what we're doing instead of quickly writing a lot of code that has serious issues. This revision is now accepted and ready to land.Apr 21 2022, 12:59 AM2022-04-21 00:59:24 (UTC-7) Closed by commit rCOMM7bc7053e2401: [services] Backup - Blob client reactors - add getStatus (authored by • karol). · Explain WhyApr 21 2022, 1:49 AM2022-04-21 01:49:22 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
|