Paths

Table of Contentst

-
services/blob/docker-server/contents/server/src/Reactors/server/base-reactors/
-
blob/
-
docker-server/
-
contents/
-
server/
-
src/
-
Reactors/
-
server/
-
base-reactors/
-
ServerWriteReactorBase.h

[services] Blob - Add server base reactor classes - write reactor
ClosedPublic
Actions

Authored by • karol on Mar 24 2022, 1:54 AM.

Details

Reviewers

• max
varun
tomek
• jim

Commits

rCOMM889b51283a2b: [services] Blob - Add server base reactor classes - write reactor

Summary

Depends on D3519

Add base reactor classes for the server to the blob service so it can use the async API

COPIED FROM services/backup/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

Test Plan

cd services
yarn run-backup-service

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Mar 24 2022, 1:54 AM

Herald added subscribers: • benschac, atul, • adrian and 2 others. · View Herald TranscriptMar 24 2022, 1:54 AM

Harbormaster completed remote builds in B7576: Diff 10647.Mar 24 2022, 2:23 AM

• karol requested review of this revision.Mar 24 2022, 2:23 AM

• karol added a child revision: D3470: [services] Blob - Add server reactor implementations - get reactor.Mar 24 2022, 2:23 AM

• karol edited the summary of this revision. (Show Details)

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, varun, tomek, • jim.

• karol added a parent revision: D3519: [services] Blob - Add server base reactor classes - read reactor.

• karol retitled this revision from [services] Blob - Add server base reactor classes - write reactor to [draft] [services] Blob - Add server base reactor classes - write reactor.Mar 24 2022, 2:47 AM

• karol edited the summary of this revision. (Show Details)Mar 24 2022, 2:57 AM

tomek accepted this revision.Mar 24 2022, 8:30 AM

This revision is now accepted and ready to land.Mar 24 2022, 8:30 AM

rebase to master

It is accepted as a draft so I removed the draft label and I'm requesting changes once again to keep the appropriate order of events.

• karol retitled this revision from [draft] [services] Blob - Add server base reactor classes - write reactor to [services] Blob - Add server base reactor classes - write reactor.Mar 25 2022, 8:31 AM

Harbormaster completed remote builds in B7612: Diff 10688.Mar 25 2022, 8:33 AM

• karol planned changes to this revision.Mar 29 2022, 1:58 AM

add status reactor

Harbormaster completed remote builds in B7663: Diff 10758.Mar 29 2022, 2:07 AM

tomek accepted this revision.Mar 30 2022, 4:06 AM

This revision is now accepted and ready to land.Mar 30 2022, 4:06 AM

ashoat added inline comments.Mar 30 2022, 10:29 PM

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
69 ↗	(On Diff #10758)	Is `delete this` really the right pattern? (I think I asked this on a different diff but I don't remember seeing the answer)

• karol added inline comments.Mar 31 2022, 11:26 PM

services/blob/src/Reactors/server/base-reactors/ServerWriteReactorBase.h
69 ↗	(On Diff #10758)	You had the same doubt in another diff, in https://phabricator.ashoat.com/D3469#97534 we seem to be on the same page about this.

Closed by commit rCOMM889b51283a2b: [services] Blob - Add server base reactor classes - write reactor (authored by • karol). · Explain WhyMar 31 2022, 11:41 PM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM889b51283a2b: [services] Blob - Add server base reactor classes - write reactor.

Revision Contents
Changeset List

Path

Size

services/

blob/

docker-server/

contents/

server/

src/

Reactors/

server/

base-reactors/

ServerWriteReactorBase.h

86 lines

Diff 10647

View Options

services/blob/docker-server/contents/server/src/Reactors/server/base-reactors/ServerWriteReactorBase.h

[services] Blob - Add server base reactor classes - write reactorClosedPublicActions