Depends on D3531
After reading the user id we want to read log chunks
Details
Details
backup service build
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 47–55 ↗ | (On Diff #11008) | We probably need a return to avoid throwing |
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 47–55 ↗ | (On Diff #11008) | I don't see what's wrong in throwing here - there should never be a state that's not handled, I think this is a good example of an exceptional/unwanted situation. Side note, effectively there's no difference between returning a grpc error and throwing, both result in terminating the reactor with a proper status (see reactor base class code). |
| services/backup/docker-server/contents/server/src/Reactors/server/SendLogReactor.h | ||
|---|---|---|
| 47–53 ↗ | (On Diff #11008) | |
| 47–55 ↗ | (On Diff #11008) | Are you sure we always want to throw when LOG_CHUNK state is processed? Because this is what happens now. I think we need a return as the last statement in case just like we have it in the other reactor. |