Page MenuHomePhabricator

[services] Backup - Blob client reactors - add getStatus
ClosedPublic

Authored by karol on Apr 13 2022, 7:04 AM.
Tags
None
Referenced Files
F3377609: D3720.id11418.diff
Wed, Nov 27, 6:38 AM
Unknown Object (File)
Sat, Nov 23, 2:32 PM
Unknown Object (File)
Sat, Nov 23, 11:33 AM
Unknown Object (File)
Wed, Nov 20, 4:32 PM
Unknown Object (File)
Wed, Nov 20, 4:31 PM
Unknown Object (File)
Wed, Nov 20, 1:55 AM
Unknown Object (File)
Tue, Nov 19, 2:59 AM
Unknown Object (File)
Sat, Nov 16, 2:48 AM

Details

Summary

Depends on D3719

We need to be able to pull the status by external objects from blob client reactors.

Test Plan
cd services
yarn run-backup-service

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

karol edited the summary of this revision. (Show Details)

remove logs

tomek requested changes to this revision.Apr 15 2022, 9:49 AM

Do we need to synchronize accessing this property?

This revision now requires changes to proceed.Apr 15 2022, 9:49 AM
In D3720#103334, @palys-swm wrote:

Do we need to synchronize accessing this property?

yes, thanks

Synchronizing accessing to state is handled in D3800. I decided it would be better to do this as a follow-up because the easiest and the cleanest way of doing it is to implement it in the master class.

In D3720#104951, @karol-bisztyga wrote:

Synchronizing accessing to state is handled in D3800. I decided it would be better to do this as a follow-up because the easiest and the cleanest way of doing it is to implement it in the master class.

It would be more efficient to think about issues like this before putting a diff - we need to spend more time planning and thinking about what we're doing instead of quickly writing a lot of code that has serious issues.
In this case, your decision makes sense, but only because we're in a state that should be avoided.

This revision is now accepted and ready to land.Apr 21 2022, 12:59 AM

Yes, I understand, this makes sense.