Page MenuHomePhabricator
Differential D10021

[Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 1:18 AM.
Tags
None
Referenced Files
F3374029: D10021.id33904.diff
Tue, Nov 26, 1:21 PM
F3373589: D10021.id33666.diff
Tue, Nov 26, 10:30 AM
F3369199: D10021.id.diff
Mon, Nov 25, 10:13 PM
Unknown Object (File)
Fri, Nov 22, 5:56 PM
Unknown Object (File)
Wed, Nov 6, 7:17 AM
Unknown Object (File)
Mon, Oct 28, 8:20 AM
Unknown Object (File)
Oct 17 2024, 11:50 AM
Unknown Object (File)
Oct 17 2024, 11:50 AM
View All 46 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMb86fcd69c4a4: [Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction
Summary

We call removeEditMode in native/navigation/tab-router.js, so it needs to be able to support a TabAction as well as ChatRouterNavigationAction. Separating this diff out because the changes are non-obvious.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10020

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24463
Build 210194: arc lint + arc unit

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 1:18 AM
ashoat created this revision.
Harbormaster completed remote builds in B24463: Diff 33666.Nov 27 2023, 1:18 AM
ashoat added inline comments.Nov 27 2023, 1:19 AM
native/navigation/nav-selectors.js
45

Snuck this change in. We still have some type-only imports that don't have the .js suffix

ashoat added a child revision: D10022: [Flow202][native][skip-ci] [38/x] Fix exponential-spread issue in RootRouter.Nov 27 2023, 1:19 AM
tomek accepted this revision.Nov 27 2023, 7:13 AM
This revision is now accepted and ready to land.Nov 27 2023, 7:13 AM
Closed by commit rCOMMb86fcd69c4a4: [Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction (authored by ashoat). · Explain WhyNov 27 2023, 3:28 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb86fcd69c4a4: [Flow202][native][skip-ci] [37/x] Allow removeEditMode to take a TabAction.

Revision Contents
Changeset List

PathSize
native/
chat/
3 lines
navigation/
2 lines

Diff 33666

View Options

native/chat/message-list-types.js

Loading...
View Options

native/navigation/nav-selectors.js

Loading...