[Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state sync specs
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 2:58 PM.

Details

Reviewers

tomek

Commits

rCOMMd441106483c6: [Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state…

Summary

There are some type issues in the state sync specs that can't be resolved with Flow. The new version of Flow is properly detecting these type issues, but there's no easy resolution.

Instead, I apply precise any-types throughout that get immediately re-cast to the proper narrowed type.

I also snuck in some type fixes in keyserver/src/socket/socket.js – will annotate them inline.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9854

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24546
Build 211028: arc lint + arc unit

Event Timeline

ashoat created this revision.Nov 13 2023, 2:58 PM

ashoat added inline comments.Nov 13 2023, 3:00 PM

keyserver/src/socket/socket.js
297 ↗	(On Diff #33169)	Flow doesn't like this because `sessionChange` is not mutable, so I rewrote the code with a `let`
333 ↗	(On Diff #33169)	Flow doesn't like this because `sessionChange` is not mutable, so I rewrote the code with a `let`

ashoat added a child revision: D9857: [Flow202][keyserver][skip-ci] [8/x] Address type errors in createPersonalThreads calling createThread.Nov 13 2023, 3:01 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:08 PM

Harbormaster failed remote builds in B24071: Diff 33169!

ashoat requested review of this revision.Nov 14 2023, 6:15 AM

tomek accepted this revision.Nov 14 2023, 7:51 AM

This revision is now accepted and ready to land.Nov 14 2023, 7:51 AM

ashoat retitled this revision from [Flow202][keyserver] [7/x] Address and hide type errors with state sync specs to [Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state sync specs.Nov 19 2023, 5:06 PM

Rebase

Harbormaster completed remote builds in B24546: Diff 33778.Nov 27 2023, 2:09 PM

Closed by commit rCOMMd441106483c6: [Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state… (authored by ashoat). · Explain WhyNov 27 2023, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMd441106483c6: [Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state….