[Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated worklets
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 1:29 AM.

Details

Reviewers

tomek

Commits

rCOMM841545027b03: [Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated…

Summary

Background here. The new Flow wants types for these functions, but Reanimated's bundler fails to strip them. To get around it, I'm using Flow's comment syntax.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10039

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24552
Build 211049: arc lint + arc unit

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 1:29 AM

ashoat created this revision.

Harbormaster completed remote builds in B24482: Diff 33685.Nov 27 2023, 1:29 AM

ashoat added a child revision: D10041: [Flow202][native][skip-ci] [57/x] Avoid looking up nullable type in non-nullable Set in ChatRouter.Nov 27 2023, 1:30 AM

tomek accepted this revision.Nov 27 2023, 7:22 AM

This revision is now accepted and ready to land.Nov 27 2023, 7:22 AM

Use Flow's comment syntax: https://flow.org/en/docs/types/comments/

Best of both worlds: keeps the types and doesn't break Reanimated

Harbormaster completed remote builds in B24551: Diff 33783.Nov 27 2023, 2:50 PM

Move some changes to D10004

Harbormaster completed remote builds in B24552: Diff 33784.Nov 27 2023, 2:52 PM

ashoat retitled this revision from [Flow202][native][skip-ci] [56/x] Add $FlowFixMe to silence errors in Reanimated worklets to [Flow202][native][skip-ci] [56/x] Add Flow's comment syntax in Reanimated worklets.Nov 27 2023, 2:54 PM

ashoat edited the summary of this revision. (Show Details)

ashoat retitled this revision from [Flow202][native][skip-ci] [56/x] Add Flow's comment syntax in Reanimated worklets to [Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated worklets.

Closed by commit rCOMM841545027b03: [Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated… (authored by ashoat). · Explain WhyNov 27 2023, 3:29 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM841545027b03: [Flow202][native][skip-ci] [56/x] Use Flow's comment syntax in Reanimated….

ashoat mentioned this in D10143: [electron-update-server] Fix minor typo.Dec 4 2023, 6:33 AM