Page MenuHomePhabricator

[Flow202][native][skip-ci] [5/x] Fix parameterization of ReactNav getParent
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 5:51 PM
Unknown Object (File)
Thu, Oct 10, 10:15 AM
Unknown Object (File)
Sep 28 2024, 10:15 PM
Unknown Object (File)
Sep 28 2024, 10:15 PM
Unknown Object (File)
Sep 28 2024, 10:14 PM
Unknown Object (File)
Sep 28 2024, 9:57 PM
Unknown Object (File)
Sep 8 2024, 11:20 PM
Unknown Object (File)
Aug 31 2024, 1:49 AM
Subscribers
None

Details

Summary

Flow was having a hard time realizing that ChatNavigationProp (definition) and TabNavigationProp (definition) are valid NavigationProps (definition, relevant line).

This diff allows us to convince Flow by providing all type params of NavigationProp at the getParent invocation.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9988

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable