[Flow202][native][skip-ci] [61/x] Get rid of Platform.select in ratchetAlongWithKeyboardHeight
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 1:31 AM.

Details

Reviewers

tomek

Commits

rCOMM8afb4e31c872: [Flow202][native][skip-ci] [61/x] Get rid of Platform.select in…

Summary

There is only case now after D1971, so the Platform.select should be removed.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10044

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 1:31 AM

ashoat created this revision.

Harbormaster completed remote builds in B24487: Diff 33690.Nov 27 2023, 1:31 AM

ashoat added a child revision: D10046: [Flow202][native] [62/x] Fill in types for all Platform.select invocations.Nov 27 2023, 1:32 AM

tomek accepted this revision.Nov 27 2023, 7:25 AM

This revision is now accepted and ready to land.Nov 27 2023, 7:25 AM

Closed by commit rCOMM8afb4e31c872: [Flow202][native][skip-ci] [61/x] Get rid of Platform.select in… (authored by ashoat). · Explain WhyNov 27 2023, 3:29 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8afb4e31c872: [Flow202][native][skip-ci] [61/x] Get rid of Platform.select in….

Revision Contents
Changeset List

Path

Size

native/

utils/

animation-utils.js

16 lines

Diff 33928

View Options

native/utils/animation-utils.js

#include "CreateNewBackupReactor.h"		#include "CreateNewBackupReactor.h"

#include "DatabaseManager.h"		#include "DatabaseManager.h"
#include "GlobalTools.h"		#include "GlobalTools.h"
#include "Tools.h"		#include "Tools.h"

		#include "blob_client/src/lib.rs.h"

namespace comm {		namespace comm {
namespace network {		namespace network {
namespace reactor {		namespace reactor {

std::string CreateNewBackupReactor::generateBackupID() {		std::string CreateNewBackupReactor::generateBackupID() {
if (this->deviceID.empty()) {		if (this->deviceID.empty()) {
throw std::runtime_error(		throw std::runtime_error(
"trying to generate a backup ID with an empty device ID");		"trying to generate a backup ID with an empty device ID");
▲ Show 20 Lines • Show All 44 Lines • ▼ Show 20 Lines	case State::DATA_HASH: {
if (database::DatabaseManager::getInstance().findBackupItem(		if (database::DatabaseManager::getInstance().findBackupItem(
this->userID, this->backupID) != nullptr) {		this->userID, this->backupID) != nullptr) {
throw std::runtime_error(		throw std::runtime_error(
"Backup with id [" + this->backupID + "] for user [" +		"Backup with id [" + this->backupID + "] for user [" +
this->userID + "] already exists, creation aborted");		this->userID + "] already exists, creation aborted");
}		}
response->set_backupid(this->backupID);		response->set_backupid(this->backupID);
this->holder = tools::generateHolder(this->dataHash, this->backupID);		this->holder = tools::generateHolder(this->dataHash, this->backupID);
// todo:blob perform put:initialize		bool dataExists = false;
		tomekUnsubmitted Not Done Inline Actions This isn't used anywhere tomek: This isn't used anywhere
		karolAuthorUnsubmitted Done Inline Actions right karol: right
		try {
		put_client_initialize_cxx();
		put_client_write_cxx(
		tools::getBlobPutField(blob::PutRequest::DataCase::kHolder),
		this->holder.c_str());
		put_client_blocking_read_cxx(); // todo this should be avoided
		// (blocking); we should be able to
		// ignore responses; we probably want to
		// delegate performing ops to separate
		// threads in the base reactors
		tomekUnsubmitted Not Done Inline Actions We should create some tasks that cover things mentioned in the comment tomek: We should create some tasks that cover things mentioned in the comment
		karolAuthorUnsubmitted Done Inline Actions https://linear.app/comm/issue/ENG-1724/solve-the-problem-with-blocked-reactors-in-grpc karol: https://linear.app/comm/issue/ENG-1724/solve-the-problem-with-blocked-reactors-in-grpc
		put_client_write_cxx(
		tools::getBlobPutField(blob::PutRequest::DataCase::kBlobHash),
		this->dataHash.c_str());

		rust::String responseStr =
		put_client_blocking_read_cxx(); // todo this should be avoided
		tomekUnsubmitted Not Done Inline Actions This is confusing. We call `put_client_blocking_read_cxx` twice, and we ignore the result once. Could you explain (preferably in code comment) what's going on here? tomek: This is confusing. We call `put_client_blocking_read_cxx` twice, and we ignore the result once.
		karolAuthorUnsubmitted Done Inline Actions We read the response to unblock the reading queue. grpc in the bidi stream always yields a response even if it's empty. And it is in this case, that's why we ignore it, but we read so the queue's not blocked (this queue is a rust's channel with `MPSC_CHANNEL_BUFFER_CAPACITY` limit). karol: We read the response to unblock the reading queue. grpc in the bidi stream always yields a…
		// (blocking); we should be able to
		// ignore responses; we probably
		// want to delegate performing ops
		// to separate threads in the base
		// reactors
		// data exists?
		if ((bool)tools::charPtrToInt(responseStr.c_str())) {
		return std::make_unique<ServerBidiReactorStatus>(
		grpc::Status::OK, true);
		}
		} catch (std::exception &e) {
		throw std::runtime_error(
		e.what()); // todo in base reactors we can just handle std exception
		// instead of keep rethrowing here
		}
return nullptr;		return nullptr;
}		}
case State::DATA_CHUNKS: {		case State::DATA_CHUNKS: {
// todo:blob perform put:add chunk		if (request.mutable_newcompactionchunk()->empty()) {
// (std::move(*request.mutable_newcompactionchunk())		return std::make_unique<ServerBidiReactorStatus>(grpc::Status::OK);
		}
		try {
		put_client_write_cxx(
		tools::getBlobPutField(blob::PutRequest::DataCase::kDataChunk),
		std::string(std::move(*request.mutable_newcompactionchunk()))
		.c_str());
		put_client_blocking_read_cxx(); // todo this should be avoided
		tomekUnsubmitted Not Done Inline Actions Why do we need to read after write? tomek: Why do we need to read after write?
		karolAuthorUnsubmitted Done Inline Actions Explained in the other comment karol: Explained in the other comment
		// (blocking); we should be able to
		// ignore responses; we probably want to
		// delegate performing ops to separate
		// threads in the base reactors
		} catch (std::exception &e) {
		throw std::runtime_error(
		e.what()); // todo in base reactors we can just handle std exception
		// instead of keep rethrowing here
		}
return nullptr;		return nullptr;
}		}
}		}
throw std::runtime_error("new backup - invalid state");		throw std::runtime_error("new backup - invalid state");
}		}

void CreateNewBackupReactor::terminateCallback() {		void CreateNewBackupReactor::terminateCallback() {
const std::lock_guard<std::mutex> lock(this->reactorStateMutex);		const std::lock_guard<std::mutex> lock(this->reactorStateMutex);
// todo:blob perform put:add chunk ("")		try {
// todo:blob perform put:wait for completion		put_client_terminate_cxx();
		} catch (std::exception &e) {
		throw std::runtime_error(
		e.what()); // todo in base reactors we can just handle std exception
		// instead of keep rethrowing here
		}

// TODO add recovery data		// TODO add recovery data
// TODO handle attachments holders		// TODO handle attachments holders
database::BackupItem backupItem(		database::BackupItem backupItem(
this->userID,		this->userID,
this->backupID,		this->backupID,
tools::getCurrentTimestamp(),		tools::getCurrentTimestamp(),
tools::generateRandomString(),		tools::generateRandomString(),
this->holder,		this->holder,
{});		{});
database::DatabaseManager::getInstance().putBackupItem(backupItem);		database::DatabaseManager::getInstance().putBackupItem(backupItem);
}		}

} // namespace reactor		} // namespace reactor
} // namespace network		} // namespace network
} // namespace comm		} // namespace comm

[Flow202][native][skip-ci] [61/x] Get rid of Platform.select in ratchetAlongWithKeyboardHeightClosedPublicActions