Page MenuHomePhabricator

[Flow202][native][skip-ci] [58/x] Destructure this.lastMessageSent before checking its value
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 3:51 AM
Unknown Object (File)
Sun, Nov 24, 12:12 AM
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 17 2024, 10:41 AM
Unknown Object (File)
Oct 7 2024, 5:33 AM
Subscribers
None

Details

Summary

The new version of Flow appears to be worried that the value of this.lastMessageSent will change after it's checked. The error goes away if I assign the value to a local variable before checking it.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10041

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24484
Build 210215: arc lint + arc unit