Page MenuHomePhabricator

[Flow202][native] [62/x] Fill in types for all Platform.select invocations
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:33 AM
Unknown Object (File)
Thu, Oct 17, 10:42 AM
Unknown Object (File)
Thu, Oct 17, 10:42 AM
Unknown Object (File)
Thu, Oct 17, 10:42 AM
Unknown Object (File)
Thu, Oct 17, 10:42 AM
Unknown Object (File)
Thu, Oct 17, 10:42 AM
Unknown Object (File)
Thu, Oct 17, 10:42 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Subscribers
None

Details

Summary

This diff will be reverted after the React Native 0.72 upgrade (tracked in ENG-5892). This diff needs to exist because I'm landing the Flow 0.202 upgrade before the React Native 0.72 upgrade.

It appears that Platform.select types are improved in later versions of React Native, and prior to those improvements these typehints are necessary.

NOTE: CI will fail on this diff, but only temporarily. Once ENG-5893 is resolved, we should expect it to pass.

Depends on D10045

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/flowupgrade
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 27 2023, 1:44 AM
Harbormaster failed remote builds in B24488: Diff 33691!
ashoat published this revision for review.Nov 27 2023, 1:45 AM
This revision is now accepted and ready to land.Nov 27 2023, 7:27 AM