[Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawData
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 2:43 PM.

Details

Reviewers

tomek

Commits

rCOMMdfbef065ab1d: [Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawData

Summary

The new Flow revealed a type error here. currentUserInfoResult is fetched conditionally in fetchUpdateInfosWithRawUpdateInfos, so it should be typed as optional.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9849

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 13 2023, 2:43 PM

ashoat added a child revision: D9851: [Flow202][keyserver][skip-ci] [3/x] Address type errors in validateCandidateMembers.

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 2:53 PM

Harbormaster failed remote builds in B24066: Diff 33164!

ashoat requested review of this revision.Nov 14 2023, 6:11 AM

tomek accepted this revision.Nov 14 2023, 7:32 AM

This revision is now accepted and ready to land.Nov 14 2023, 7:32 AM

ashoat retitled this revision from [Flow202][keyserver] [2/x] Address type error in UpdateInfosRawData to [Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawData.Nov 19 2023, 5:05 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMMdfbef065ab1d: [Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawData (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdfbef065ab1d: [Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawData.

Revision Contents
Changeset List

Path

Size

lib/

shared/

updates/

update-spec.js

2 lines

Diff 33164

View Options

lib/shared/updates/update-spec.js

	import ExpoModulesCore			import ExpoModulesCore
				import CryptoKit

	public class AESCryptoModule: Module {			public class AESCryptoModule: Module {
	public func definition() -> ModuleDefinition {			public func definition() -> ModuleDefinition {
	Name("AESCrypto")			Name("AESCrypto")

	Function("hello") { () -> String in			Function("generateKey", generateKey)
	return "Hello world! 👋"
	}			}
	}			}

				// MARK: - Function implementations

				private func generateKey(destination: Uint8Array) throws {
				let key = SymmetricKey(size: .bits256)
				guard destination.byteLength * 8 == key.bitCount else {
				throw InvalidKeyLengthException()
				}
				atulUnsubmitted Not Done Inline Actions Before we even generate `key` via `SymmetricKey`, should we check that `destination.byteLength` is `32` and throw `InvalidDestinationSizeException()` if not? It seems like `destination` is the input that we want to validate, so we should just do that directly? It's not really so much that `SymmetricKey` is giving us incorrect size `key` since it's (I'm assuming) always going to give us exactly the size we're asking for? Feel free to re-request review if there's something I'm missing here. atul: Before we even generate `key` via `SymmetricKey`, should we check that `destination.byteLength`…
				bartekAuthorUnsubmitted Done Inline Actions The only reason the guard is below `SymmetricKey` is that I wanted to use its `bitCount` property to get the desired destination length, but you're right that it can be done this way: guard destination.byteLength == KEY_SIZE else { throw InvalidKeyLengthException() } let key = SymmetricKey(size: .bits256) I'll refactor this as it is more clear solution bartek: The only reason the guard is below `SymmetricKey` is that I wanted to use its `bitCount`…

				key.withUnsafeBytes { bytes in
				let _ = bytes.copyBytes(to: destination.rawBufferPtr())
				}
				}

				// MARK: - Utilities

				extension TypedArray {
				func rawBufferPtr() -> UnsafeMutableRawBufferPointer {
				UnsafeMutableRawBufferPointer(start: self.rawPointer,
				count: self.byteLength)
				}
				}

				// MARK: - Exception definitions

				private class InvalidKeyLengthException: Exception {
				override var reason: String {
				"The AES key has invalid length"
				}
	}			}

[Flow202][keyserver][skip-ci] [2/x] Address type error in UpdateInfosRawDataClosedPublicActions